Merge branch 'spec_tweak' into 'master'

Avoid create in prometheus_alert_entity_spec and release_serializer_spec

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/106796



Merged-by: Vitali Tatarintev <vtatarintev@gitlab.com>
Approved-by: Alina Mihaila <amihaila@gitlab.com>
Approved-by: Vitali Tatarintev <vtatarintev@gitlab.com>
Reviewed-by: Alina Mihaila <amihaila@gitlab.com>
Co-authored-by: lyb124553153 <124553153@qq.com>

.rubocop_todo/rspec/factory_bot/avoid_create.yml

@@ -535,8 +535,6 @@ RSpec/FactoryBot/AvoidCreate:
     - 'spec/serializers/project_mirror_entity_spec.rb'
     - 'spec/serializers/project_note_entity_spec.rb'
     - 'spec/serializers/project_serializer_spec.rb'
-    - 'spec/serializers/prometheus_alert_entity_spec.rb'
-    - 'spec/serializers/release_serializer_spec.rb'
     - 'spec/serializers/review_app_setup_entity_spec.rb'
     - 'spec/serializers/runner_entity_spec.rb'
     - 'spec/serializers/serverless/domain_entity_spec.rb'

spec/serializers/prometheus_alert_entity_spec.rb

@@ -3,8 +3,8 @@
 require 'spec_helper'
 
 RSpec.describe PrometheusAlertEntity do
-  let(:user) { create(:user) }
-  let(:prometheus_alert) { create(:prometheus_alert) }
+  let(:user) { build_stubbed(:user) }
+  let(:prometheus_alert) { build_stubbed(:prometheus_alert) }
   let(:request) { double('prometheus_alert', current_user: user) }
   let(:entity) { described_class.new(prometheus_alert, request: request) }
 

spec/serializers/release_serializer_spec.rb

@@ -3,18 +3,13 @@
 require 'spec_helper'
 
 RSpec.describe ReleaseSerializer do
-  let(:user) { create(:user) }
-  let(:project) { create :project }
+  let(:user) { build_stubbed(:user) }
 
   subject { described_class.new.represent(resource, current_user: user) }
 
-  before do
-    project.add_developer(user)
-  end
-
   describe '#represent' do
     context 'when a single object is being serialized' do
-      let(:resource) { create(:release, project: project) }
+      let(:resource) { build_stubbed(:release) }
 
       it 'serializes the label object' do
         expect(subject[:tag]).to eq resource.tag
@@ -26,7 +21,7 @@
     end
 
     context 'when multiple objects are being serialized' do
-      let(:resource) { create_list(:release, 3) }
+      let(:resource) { build_stubbed_list(:release, 3) }
 
       it 'serializes the array of releases' do
         expect(subject.size).to eq(3)