Merge branch '225888-replace-fa-download-icon-with-gitlab-svg-download-icon' into 'master'

Replace fa-download icon with GitLab SVG download icon

Closes #225888

See merge request gitlab-org/gitlab!39849

app/assets/stylesheets/fontawesome_custom.scss

@@ -250,10 +250,6 @@
   content: '\f06d';
 }
 
-.fa-download::before {
-  content: '\f019';
-}
-
 .fa-globe::before {
   content: '\f0ac';
 }

app/helpers/snippets_helper.rb

@@ -12,7 +12,7 @@ def snippets_upload_path(snippet, user)
   end
 
   def download_raw_snippet_button(snippet)
-    link_to(icon('download'),
+    link_to(sprite_icon('download'),
             gitlab_raw_snippet_path(snippet, inline: false),
             target: '_blank',
             rel: 'noopener noreferrer',

changelogs/unreleased/225888-replace-fa-download-icon-with-gitlab-svg-download-icon.yml

+---
+title: Replace fa-download icon with GitLab SVG download icon
+merge_request: 39849
+author:
+type: changed

spec/helpers/snippets_helper_spec.rb

@@ -109,7 +109,7 @@ def script_embed(url)
     end
 
     def download_link(url)
-      "<a target=\"_blank\" rel=\"noopener noreferrer\" class=\"btn btn-sm has-tooltip\" title=\"Download\" data-container=\"body\" href=\"#{url}?inline=false\"><i aria-hidden=\"true\" data-hidden=\"true\" class=\"fa fa-download\"></i></a>"
+      "<a target=\"_blank\" rel=\"noopener noreferrer\" class=\"btn btn-sm has-tooltip\" title=\"Download\" data-container=\"body\" href=\"#{url}?inline=false\">#{sprite_icon('download')}</a>"
     end
   end