Merge branch 'bmarjanovic/static-integration-dsl-app-models-integrations-pumble' into 'master'

Convert Pumble integration to use DSL

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127397



Merged-by: Douglas Barbosa Alexandre <dbalexandre@gmail.com>
Approved-by: Douglas Barbosa Alexandre <dbalexandre@gmail.com>
Approved-by: Michael Becker <11881043-wandering_person@users.noreply.gitlab.com>
Reviewed-by: Bojan Marjanovic <bmarjanovic@gitlab.com>
Reviewed-by: Michael Becker <11881043-wandering_person@users.noreply.gitlab.com>
Co-authored-by: bmarjanovic <bmarjanovic@gitlab.com>

app/models/integrations/pumble.rb

@@ -2,6 +2,24 @@
 
 module Integrations
   class Pumble < BaseChatNotification
+    undef :notify_only_broken_pipelines
+
+    field :webhook,
+      section: SECTION_TYPE_CONNECTION,
+      help: 'https://api.pumble.com/workspaces/x/...',
+      required: true
+
+    field :notify_only_broken_pipelines,
+      type: 'checkbox',
+      section: SECTION_TYPE_CONFIGURATION,
+      help: 'If selected, successful pipelines do not trigger a notification event.'
+
+    field :branches_to_be_notified,
+      type: 'select',
+      section: SECTION_TYPE_CONFIGURATION,
+      title: -> { s_('Integrations|Branches for which notifications are to be sent') },
+      choices: -> { branch_choices }
+
     def title
       'Pumble'
     end
@@ -34,17 +52,8 @@ def self.supported_events
          pipeline wiki_page]
     end
 
-    def default_fields
-      [
-        { type: 'text', name: 'webhook', help: 'https://api.pumble.com/workspaces/x/...', required: true },
-        { type: 'checkbox', name: 'notify_only_broken_pipelines' },
-        {
-          type: 'select',
-          name: 'branches_to_be_notified',
-          title: s_('Integrations|Branches for which notifications are to be sent'),
-          choices: self.class.branch_choices
-        }
-      ]
+    def fields
+      self.class.fields + build_event_channels
     end
 
     private

spec/models/integrations/pumble_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-RSpec.describe Integrations::Pumble do
+RSpec.describe Integrations::Pumble, feature_category: :integrations do
   it_behaves_like "chat integration", "Pumble" do
     let(:client_arguments) { webhook_url }
     let(:payload) do