Merge branch '430252-fix-missing-banner-on-behavior-dashboards' into 'master'

Fix feedback banner not showing on behavior dashboards

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/141753



Merged-by: Robert Hunt <rhunt@gitlab.com>
Approved-by: Robert Hunt <rhunt@gitlab.com>
Approved-by: Elwyn Benson <ebenson@gitlab.com>
Reviewed-by: Elwyn Benson <ebenson@gitlab.com>
Co-authored-by: Jiaan Louw <jlouw@gitlab.com>

ee/app/assets/javascripts/analytics/dashboards/constants.js

@@ -265,7 +265,7 @@ export const DORA_PERFORMERS_SCORE_CHART_COLOR_PALETTE = [GREEN_400, ORANGE_400,
 // the slug name for a dashboard must match the URL path that is used
 export const BUILT_IN_VALUE_STREAM_DASHBOARD = 'value_streams_dashboard';
 
-export const BUILT_IN_PRODUCT_ANALYTICS_DASHBOARDS = ['behaviour', 'audience'];
+export const BUILT_IN_PRODUCT_ANALYTICS_DASHBOARDS = ['behavior', 'audience'];
 
 export const VISUALIZATION_USAGE_OVERVIEW = 'usage_overview';
 export const VISUALIZATION_USAGE_TITLE = s__('Analytics|Usage overview for %{namespaceName} group');

ee/spec/frontend/analytics/analytics_dashboards/components/analytics_dashboard_spec.js

@@ -611,11 +611,11 @@ describe('AnalyticsDashboard', () => {
 
   describe('with a built-in product analytics dashboards dashboard', () => {
     it.each`
-      slug           | userDefined | showsBanner
-      ${'audience'}  | ${false}    | ${true}
-      ${'behaviour'} | ${false}    | ${true}
-      ${'vsd'}       | ${false}    | ${false}
-      ${'audience'}  | ${true}     | ${false}
+      slug          | userDefined | showsBanner
+      ${'audience'} | ${false}    | ${true}
+      ${'behavior'} | ${false}    | ${true}
+      ${'vsd'}      | ${false}    | ${false}
+      ${'audience'} | ${true}     | ${false}
     `(
       'when the dashboard slug is "$slug" and userDefined is $userDefined then the banner is $showsBanner',
       async ({ slug, userDefined, showsBanner }) => {