Merge branch '510203-try-removing-the-scope' into 'master'

Remove scope visible_to_user_and_access_level from Vulnerability model

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/180141



Merged-by: Gregory Havenga <11164960-ghavenga@users.noreply.gitlab.com>
Approved-by: Schmil Monderer <smonderer@gitlab.com>
Approved-by: Gregory Havenga <11164960-ghavenga@users.noreply.gitlab.com>
Reviewed-by: Schmil Monderer <smonderer@gitlab.com>
Co-authored-by: Arpit Gogia <12347103-arpitgogia@users.noreply.gitlab.com>

ee/app/models/ee/vulnerability.rb

@@ -84,11 +84,6 @@ module Vulnerability
       scope :with_findings_excluding_uuid, ->(uuid) { joins(:findings).merge(Vulnerabilities::Finding.excluding_uuids(uuid)) }
       scope :with_findings_scanner_and_identifiers, -> { includes(findings: [:scanner, :identifiers, { finding_identifiers: :identifier }]) }
       scope :with_findings_scanner_identifiers_and_notes, -> { with_findings_scanner_and_identifiers.includes(:notes) }
-      scope :visible_to_user_and_access_level, ->(user, access_level) {
-        where(
-          project_id: ::Project.visible_to_user_and_access_level(user, access_level)
-        .distinct.pluck_primary_key)
-      }
       scope :with_report_types, ->(report_types) { where(report_type: report_types) }
       scope :with_severities, ->(severities) { where(severity: severities) }
       scope :with_states, ->(states) { where(state: states) }

ee/spec/models/ee/vulnerability_spec.rb

@@ -107,22 +107,6 @@
     end
   end
 
-  describe '.visible_to_user_and_access_level' do
-    let(:project_2) { create(:project) }
-
-    before do
-      project.add_developer(user)
-
-      create(:vulnerability, project: project_2)
-    end
-
-    subject { described_class.visible_to_user_and_access_level(user, ::Gitlab::Access::DEVELOPER) }
-
-    it 'returns vulnerabilities visible for given user with provided access level' do
-      is_expected.to contain_exactly(vulnerability)
-    end
-  end
-
   describe '.with_limit' do
     subject(:limited_vulnerabilities) { described_class.with_limit(1) }