Skip to content
代码片段 群组 项目
未验证 提交 199069e3 编辑于 作者: Rahul Chanila's avatar Rahul Chanila 提交者: GitLab
浏览文件

Modifies GAR list page header metadata items

Screenreader support is better

EE: true
上级 293ddfa5
No related branches found
No related tags found
无相关合并请求
<script> <script>
import { GlAlert, GlButton, GlTooltipDirective } from '@gitlab/ui'; import { GlAlert, GlButton, GlTooltipDirective } from '@gitlab/ui';
import { s__ } from '~/locale'; import { s__, sprintf } from '~/locale';
import MetadataItem from '~/vue_shared/components/registry/metadata_item.vue'; import MetadataItem from '~/vue_shared/components/registry/metadata_item.vue';
import TitleArea from '~/vue_shared/components/registry/title_area.vue'; import TitleArea from '~/vue_shared/components/registry/title_area.vue';
...@@ -40,6 +40,16 @@ export default { ...@@ -40,6 +40,16 @@ export default {
showActions() { showActions() {
return !this.isLoading && !this.showError; return !this.isLoading && !this.showError;
}, },
projectIdMetadata() {
return sprintf(s__('GoogleArtifactRegistry|Project ID: %{projectId}'), {
projectId: this.data.projectId,
});
},
repositoryMetadata() {
return sprintf(s__('GoogleArtifactRegistry|Repository: %{repository}'), {
repository: this.data.repository,
});
},
}, },
i18n: { i18n: {
settingsText: s__('GoogleArtifactRegistry|Configure in settings'), settingsText: s__('GoogleArtifactRegistry|Configure in settings'),
...@@ -74,19 +84,12 @@ export default { ...@@ -74,19 +84,12 @@ export default {
<metadata-item <metadata-item
data-testid="repository-name" data-testid="repository-name"
icon="folder" icon="folder"
:text="data.repository" :text="repositoryMetadata"
:text-tooltip="s__('GoogleArtifactRegistry|Repository name')" size="l"
size="xl"
/> />
</template> </template>
<template v-if="showMetadata" #metadata-project> <template v-if="showMetadata" #metadata-project>
<metadata-item <metadata-item data-testid="project-id" icon="project" :text="projectIdMetadata" size="l" />
data-testid="project-id"
icon="project"
:text="data.projectId"
:text-tooltip="s__('GoogleArtifactRegistry|Project ID')"
size="xl"
/>
</template> </template>
<gl-alert v-if="showError" variant="danger" :dismissible="false"> <gl-alert v-if="showError" variant="danger" :dismissible="false">
{{ s__('GoogleArtifactRegistry|An error occurred while fetching the artifacts.') }} {{ s__('GoogleArtifactRegistry|An error occurred while fetching the artifacts.') }}
......
...@@ -103,10 +103,9 @@ describe('Google Artifact Registry list page header', () => { ...@@ -103,10 +103,9 @@ describe('Google Artifact Registry list page header', () => {
createComponent(); createComponent();
expect(findRepositoryNameSubHeader().props()).toMatchObject({ expect(findRepositoryNameSubHeader().props()).toMatchObject({
text: defaultProps.data.repository,
textTooltip: 'Repository name',
icon: 'folder', icon: 'folder',
size: 'xl', text: `Repository: ${defaultProps.data.repository}`,
size: 'l',
}); });
}); });
}); });
...@@ -116,10 +115,9 @@ describe('Google Artifact Registry list page header', () => { ...@@ -116,10 +115,9 @@ describe('Google Artifact Registry list page header', () => {
createComponent(); createComponent();
expect(findProjectIDSubHeader().props()).toMatchObject({ expect(findProjectIDSubHeader().props()).toMatchObject({
text: defaultProps.data.projectId,
textTooltip: 'Project ID',
icon: 'project', icon: 'project',
size: 'xl', text: `Project ID: ${defaultProps.data.projectId}`,
size: 'l',
}); });
}); });
}); });
......
...@@ -23312,7 +23312,7 @@ msgstr "" ...@@ -23312,7 +23312,7 @@ msgstr ""
msgid "GoogleArtifactRegistry|Project" msgid "GoogleArtifactRegistry|Project"
msgstr "" msgstr ""
   
msgid "GoogleArtifactRegistry|Project ID" msgid "GoogleArtifactRegistry|Project ID: %{projectId}"
msgstr "" msgstr ""
   
msgid "GoogleArtifactRegistry|Push new ones from your CI/CD pipeline." msgid "GoogleArtifactRegistry|Push new ones from your CI/CD pipeline."
...@@ -23321,7 +23321,7 @@ msgstr "" ...@@ -23321,7 +23321,7 @@ msgstr ""
msgid "GoogleArtifactRegistry|Repository" msgid "GoogleArtifactRegistry|Repository"
msgstr "" msgstr ""
   
msgid "GoogleArtifactRegistry|Repository name" msgid "GoogleArtifactRegistry|Repository: %{repository}"
msgstr "" msgstr ""
   
msgid "GoogleArtifactRegistry|Tags" msgid "GoogleArtifactRegistry|Tags"
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册