Merge branch 'pedropombeiro/494933/fix-tests-schema' into 'master'

Change gitlab_schema default value in have_scheduled_batched_migration matcher

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167570



Merged-by: Pedro Pombeiro <noreply@pedro.pombei.ro>
Approved-by: Eva Kadlecová <ekadlecova@gitlab.com>
Approved-by: Bojan Marjanovic <bmarjanovic@gitlab.com>
Approved-by: Ethan Urie <eurie@gitlab.com>
Approved-by: Jarka Košanová <jarka@gitlab.com>
Reviewed-by: Lucas Charles <me@lucascharles.me>
Reviewed-by: Pedro Pombeiro <noreply@pedro.pombei.ro>
Reviewed-by: Ethan Urie <eurie@gitlab.com>

lib/generators/batched_background_migration/templates/queue_batched_background_migration_spec.template

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe <%= migration_class_name %>, feature_category: :<%= feature_category.to_sym %> do
+RSpec.describe <%= migration_class_name %>, migration: :gitlab_?, feature_category: :<%= feature_category.to_sym %> do
   # let!(:batched_migration) { described_class::MIGRATION }
 
   # it 'schedules a new batched migration' do
@@ -14,6 +14,7 @@ RSpec.describe <%= migration_class_name %>, feature_category: :<%= feature_categ
 
   #     migration.after -> {
   #       expect(batched_migration).to have_scheduled_batched_migration(
+  #         gitlab_schema: # :gitlab_main / :gitlab_ci / :gitlab_main_clusterwide / ...
   #         table_name: :<%= table_name %>,
   #         column_name: :<%= column_name %>,
   #         interval: described_class::DELAY_INTERVAL,

spec/lib/generators/batched_background_migration/expected_files/queue_my_batched_migration_spec.txt

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueMyBatchedMigration, feature_category: :database do
+RSpec.describe QueueMyBatchedMigration, migration: :gitlab_?, feature_category: :database do
   # let!(:batched_migration) { described_class::MIGRATION }
 
   # it 'schedules a new batched migration' do
@@ -14,6 +14,7 @@ RSpec.describe QueueMyBatchedMigration, feature_category: :database do
 
   #     migration.after -> {
   #       expect(batched_migration).to have_scheduled_batched_migration(
+  #         gitlab_schema: # :gitlab_main / :gitlab_ci / :gitlab_main_clusterwide / ...
   #         table_name: :projects,
   #         column_name: :id,
   #         interval: described_class::DELAY_INTERVAL,

spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb

@@ -195,6 +195,7 @@
 
   before do
     allow(migration).to receive(:puts)
+    allow(described_class).to receive(:allowed_gitlab_schemas).and_return([:gitlab_main])
 
     migration.create_table source_table do |t|
       t.string :name, null: false

spec/migrations/20240214203242_queue_backfill_sbom_occurrences_traversal_ids_and_archived_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillSbomOccurrencesTraversalIdsAndArchived, feature_category: :dependency_management do
+RSpec.describe QueueBackfillSbomOccurrencesTraversalIdsAndArchived, migration: :gitlab_sec,
+  feature_category: :dependency_management do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240223130548_queue_update_sbom_components_name_based_on_pep503_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueUpdateSbomComponentsNameBasedOnPep503, feature_category: :software_composition_analysis do
+RSpec.describe QueueUpdateSbomComponentsNameBasedOnPep503, migration: :gitlab_sec,
+  feature_category: :software_composition_analysis do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240226143323_queue_backup_and_remove_notes_with_null_noteable_type_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackupAndRemoveNotesWithNullNoteableType, feature_category: :team_planning do
+RSpec.describe QueueBackupAndRemoveNotesWithNullNoteableType, migration: :gitlab_main_cell,
+  feature_category: :team_planning do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240306120522_queue_update_sbom_occurrences_component_name_based_on_pep503_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueUpdateSbomOccurrencesComponentNameBasedOnPep503, feature_category: :software_composition_analysis do
+RSpec.describe QueueUpdateSbomOccurrencesComponentNameBasedOnPep503, migration: :gitlab_sec,
+  feature_category: :software_composition_analysis do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240410004337_queue_backfill_deployment_approvals_project_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillDeploymentApprovalsProjectId, feature_category: :continuous_delivery do
+RSpec.describe QueueBackfillDeploymentApprovalsProjectId, migration: :gitlab_main_cell,
+  feature_category: :continuous_delivery do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240501044351_queue_backfill_approval_merge_request_rules_project_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillApprovalMergeRequestRulesProjectId, feature_category: :code_review_workflow do
+RSpec.describe QueueBackfillApprovalMergeRequestRulesProjectId, migration: :gitlab_main_cell,
+  feature_category: :code_review_workflow do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240501044505_queue_backfill_approval_project_rules_users_project_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillApprovalProjectRulesUsersProjectId, feature_category: :source_code_management do
+RSpec.describe QueueBackfillApprovalProjectRulesUsersProjectId, migration: :gitlab_main_cell,
+  feature_category: :source_code_management do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240507152320_queue_migrate_os_sbom_occurrences_to_components_without_prefix_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueMigrateOsSbomOccurrencesToComponentsWithoutPrefix, feature_category: :software_composition_analysis do
+RSpec.describe QueueMigrateOsSbomOccurrencesToComponentsWithoutPrefix, migration: :gitlab_sec,
+  feature_category: :software_composition_analysis do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240515155063_queue_backfill_design_management_designs_namespace_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillDesignManagementDesignsNamespaceId, feature_category: :design_management do
+RSpec.describe QueueBackfillDesignManagementDesignsNamespaceId, migration: :gitlab_main_cell,
+  feature_category: :design_management do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240521090846_queue_backfill_boards_epic_board_labels_group_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillBoardsEpicBoardLabelsGroupId, feature_category: :portfolio_management do
+RSpec.describe QueueBackfillBoardsEpicBoardLabelsGroupId, migration: :gitlab_main_cell,
+  feature_category: :portfolio_management do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240521093524_queue_backfill_boards_epic_lists_group_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillBoardsEpicListsGroupId, feature_category: :portfolio_management do
+RSpec.describe QueueBackfillBoardsEpicListsGroupId, migration: :gitlab_main_cell,
+  feature_category: :portfolio_management do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240529112047_queue_backfill_wiki_page_slugs_project_id_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillWikiPageSlugsProjectId, feature_category: :wiki do
+RSpec.describe QueueBackfillWikiPageSlugsProjectId, migration: :gitlab_main_cell, feature_category: :wiki do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240529123638_queue_backfill_packages_build_infos_project_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillPackagesBuildInfosProjectId, feature_category: :package_registry do
+RSpec.describe QueueBackfillPackagesBuildInfosProjectId, migration: :gitlab_main_cell,
+  feature_category: :package_registry do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240529185029_queue_backfill_dora_daily_metrics_project_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillDoraDailyMetricsProjectId, feature_category: :continuous_delivery do
+RSpec.describe QueueBackfillDoraDailyMetricsProjectId, migration: :gitlab_main_cell,
+  feature_category: :continuous_delivery do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240530121656_queue_backfill_design_management_versions_namespace_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillDesignManagementVersionsNamespaceId, feature_category: :design_management do
+RSpec.describe QueueBackfillDesignManagementVersionsNamespaceId, migration: :gitlab_main_cell,
+  feature_category: :design_management do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240531202753_queue_backfill_or_drop_ci_pipeline_on_project_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillOrDropCiPipelineOnProjectId, migration: :gitlab_ci, feature_category: :continuous_integration do
+RSpec.describe QueueBackfillOrDropCiPipelineOnProjectId, migration: :gitlab_ci,
+  feature_category: :continuous_integration do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do

spec/migrations/20240603121642_queue_backfill_dast_pre_scan_verifications_project_id_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 require_migration!
 
-RSpec.describe QueueBackfillDastPreScanVerificationsProjectId, feature_category: :dynamic_application_security_testing do
+RSpec.describe QueueBackfillDastPreScanVerificationsProjectId, migration: :gitlab_sec,
+  feature_category: :dynamic_application_security_testing do
   let!(:batched_migration) { described_class::MIGRATION }
 
   it 'schedules a new batched migration' do
@@ -19,7 +20,7 @@
           interval: described_class::DELAY_INTERVAL,
           batch_size: described_class::BATCH_SIZE,
           sub_batch_size: described_class::SUB_BATCH_SIZE,
-          gitlab_schema: :gitlab_main_cell,
+          gitlab_schema: :gitlab_sec,
           job_arguments: [
             :project_id,
             :dast_profiles,