Merge branch '503306-drop-namespace_details-pending_delete-column' into 'master'

Drop namespace_details.pending_delete column

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/173383



Merged-by: Eugenia Grieff <egrieff@gitlab.com>
Approved-by: Max Woolf <mwoolf@gitlab.com>
Approved-by: Michał Zając <mzajac@gitlab.com>
Approved-by: Sam Figueroa <sfigueroa@gitlab.com>
Approved-by: Eugenia Grieff <egrieff@gitlab.com>
Co-authored-by: Shane Maglangit <smaglangit@gitlab.com>

app/models/namespace/detail.rb

@@ -7,7 +7,7 @@ class Namespace::Detail < ApplicationRecord
   validates :namespace, presence: true
   validates :description, length: { maximum: 255 }
 
-  ignore_column :pending_delete, remove_with: '17.7', remove_after: '2024-11-22'
+  ignore_column :pending_delete, remove_with: '17.8', remove_after: '2024-12-13'
 
   self.primary_key = :namespace_id
 

db/post_migrate/20241121090148_remove_namespace_pending_delete_column.rb

+# frozen_string_literal: true
+
+class RemoveNamespacePendingDeleteColumn < Gitlab::Database::Migration[2.2]
+  milestone '17.7'
+
+  def up
+    remove_column :namespace_details, :pending_delete
+  end
+
+  def down
+    add_column :namespace_details, :pending_delete, :boolean, default: false, null: false
+  end
+end

db/schema_migrations/20241121090148

+a44e559fb025b209754641f697bed11e39657fb61076e0288ff9e011628590b5
\ No newline at end of file

db/structure.sql

@@ -15044,7 +15044,6 @@ CREATE TABLE namespace_details (
     description text,
     description_html text,
     creator_id bigint,
-    pending_delete boolean DEFAULT false NOT NULL,
     deleted_at timestamp with time zone
 );