Merge branch 'led/387958-remove-dismissal-error-storage-alert' into 'master'

Remove dismiss button for storage alerts that require user attention

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/122494



Merged-by: Dylan Griffith <dyl.griffith@gmail.com>
Approved-by: Dylan Griffith <dyl.griffith@gmail.com>
Approved-by: Mohamed Hamda <mhamda@gitlab.com>
Reviewed-by: Mohamed Hamda <mhamda@gitlab.com>
Co-authored-by: Sheldon Led <sheldonled@gitlab.com>

ee/app/components/namespaces/storage/limit_alert_component.html.haml

 .gl-mt-3.container-fluid{ class: content_class }
   = render Pajamas::AlertComponent.new(variant: alert_variant,
-    dismissible: true,
+    dismissible: dismissible?,
     title: alert_title,
     alert_options: { class: 'js-namespace-storage-alert',
                     data: { feature_id: callout_feature_name,

ee/app/components/namespaces/storage/limit_alert_component.rb

@@ -45,13 +45,13 @@ def alert_message
       end
 
       def alert_variant
-        return :danger if [:alert, :error].include?(alert_level)
+        return :danger if attention_required_alert_level?
 
         alert_level
       end
 
       def alert_icon
-        [:alert, :error].include?(alert_level) ? 'error' : alert_level.to_s
+        attention_required_alert_level? ? 'error' : alert_level.to_s
       end
 
       def alert_callout_path
@@ -82,6 +82,14 @@ def content_class
         "container-limited limit-container-width" unless user.layout == "fluid"
       end
 
+      def dismissible?
+        !attention_required_alert_level?
+      end
+
+      def attention_required_alert_level?
+        [:alert, :error].include?(alert_level)
+      end
+
       def alert_level
         usage_thresholds = {
           none: 0.0,

ee/spec/components/namespaces/storage/limit_alert_component_spec.rb

@@ -75,6 +75,11 @@
           render_inline(component)
           expect(page).to have_content(alert_message_below_limit)
         end
+
+        it 'allows to dismiss alert' do
+          render_inline(component)
+          expect(page).to have_css("[data-testid='close-icon']")
+        end
       end
 
       context 'and above storage size limit' do
@@ -90,6 +95,11 @@
           render_inline(component)
           expect(page).to have_content(alert_message_above_limit_no_purchased_storage)
         end
+
+        it 'does not allow to dismiss alert' do
+          render_inline(component)
+          expect(page).not_to have_css("[data-testid='close-icon']")
+        end
       end
     end