Merge branch '239356-rails-http-status' into 'master'

Fix Rails/HttpStatus

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/105564



Merged-by: Jan Provaznik <jprovaznik@gitlab.com>
Approved-by: Jonathan Schafer <jschafer@gitlab.com>
Approved-by: Jan Provaznik <jprovaznik@gitlab.com>
Co-authored-by: Mohammad Aseem <mhdasm3@gmail.com>

.rubocop_todo/rails/http_status.yml

----
-# Cop supports --autocorrect.
-Rails/HttpStatus:
-  Exclude:
-    - 'app/controllers/concerns/invisible_captcha_on_signup.rb'
-    - 'app/controllers/projects/runner_projects_controller.rb'
-    - 'app/controllers/projects/service_ping_controller.rb'
-    - 'app/controllers/repositories/lfs_storage_controller.rb'
-    - 'ee/app/controllers/trials_controller.rb'

app/controllers/concerns/invisible_captcha_on_signup.rb

@@ -13,7 +13,7 @@ def on_honeypot_spam_callback
     invisible_captcha_honeypot_counter.increment
     log_request('Invisible_Captcha_Honeypot_Request')
 
-    head(200)
+    head(:ok)
   end
 
   def on_timestamp_spam_callback

app/controllers/projects/runner_projects_controller.rb

@@ -11,7 +11,7 @@ class Projects::RunnerProjectsController < Projects::ApplicationController
   def create
     @runner = Ci::Runner.find(params[:runner_project][:runner_id])
 
-    return head(403) unless can?(current_user, :assign_runner, @runner)
+    return head(:forbidden) unless can?(current_user, :assign_runner, @runner)
 
     path = project_runners_path(project)
 

app/controllers/projects/service_ping_controller.rb

@@ -10,7 +10,7 @@ def web_ide_clientside_preview
 
     Gitlab::UsageDataCounters::WebIdeCounter.increment_previews_count
 
-    head(200)
+    head(:ok)
   end
 
   def web_ide_clientside_preview_success
@@ -20,12 +20,12 @@ def web_ide_clientside_preview_success
     Gitlab::UsageDataCounters::EditorUniqueCounter.track_live_preview_edit_action(author: current_user,
                                                                                   project: project)
 
-    head(200)
+    head(:ok)
   end
 
   def web_ide_pipelines_count
     Gitlab::UsageDataCounters::WebIdeCounter.increment_pipelines_count
 
-    head(200)
+    head(:ok)
   end
 end

app/controllers/repositories/lfs_storage_controller.rb

@@ -49,7 +49,7 @@ def upload_finalize
       validate_uploaded_file!
 
       if store_file!(oid, size)
-        head 200, content_type: LfsRequest::CONTENT_TYPE
+        head :ok, content_type: LfsRequest::CONTENT_TYPE
       else
         render plain: 'Unprocessable entity', status: :unprocessable_entity
       end

ee/app/controllers/trials_controller.rb

@@ -48,7 +48,7 @@ def create_hand_raise_lead
     result = GitlabSubscriptions::CreateHandRaiseLeadService.new.execute(hand_raise_lead_params)
 
     if result.success?
-      head 200
+      head :ok
     else
       render_403
     end
@@ -64,7 +64,7 @@ def extend_reactivate
     result = GitlabSubscriptions::ExtendReactivateTrialService.new.execute(extend_reactivate_trial_params) if valid_extension?
 
     if result&.success?
-      head 200
+      head :ok
     else
       render_403
     end