Merge branch 'fa-rename_outdated_requirement_issue_factory' into 'master'

Rename requirement_issue factory to requirement

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143238



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Eugenia Grieff <egrieff@gitlab.com>
Co-authored-by: Felipe Artur <felipefac@gmail.com>

ee/spec/factories/issues.rb

@@ -14,11 +14,8 @@
   end
 end
 
-# There is another factory called :requirement for RequirementManagement::Requirement.
-# We are converting that class into an issue type. We can rename this as :requirement
-# when migration is completed. More information at https://gitlab.com/gitlab-org/gitlab/-/issues/323779
 FactoryBot.define do
-  factory :requirement_issue, parent: :issue do
+  factory :requirement, parent: :issue do
     association :work_item_type, :default, :requirement
   end
 end

ee/spec/factories/requirements_management/test_reports.rb

@@ -3,7 +3,7 @@
 FactoryBot.define do
   factory :test_report, class: 'RequirementsManagement::TestReport' do
     author
-    requirement_issue
+    requirement_issue factory: :requirement
     build factory: :ci_build
     state { :passed }
   end

ee/spec/services/ee/notes/quick_actions_service_spec.rb

@@ -642,7 +642,7 @@ def execute(note, include_message: false)
 
       context 'for requirement' do
         it_behaves_like 'note on issue type that does not support time tracking' do
-          let(:noteable) { create(:requirement_issue, project: project) }
+          let(:noteable) { create(:requirement, project: project) }
         end
       end
 

ee/spec/support/shared_examples/models/requirement_issues_examples.rb

@@ -9,7 +9,7 @@
       requirement
     end
 
-    let(:requirement_issue) { build(:requirement_issue) }
+    let(:requirement_issue) { build(:requirement) }
 
     context 'when the requirement issue is of type requirement' do
       let(:requirement_issue_arg) { requirement_issue }