-
- 下载
Merge branch 'enable-rubocop-for-migrations' into 'master'
Enable RuboCop for migrations ## What does this MR do? Enable RuboCop for all files inside `db/migrate`, then add magic comments to all existing files, so that this only affects new migrations. ## Are there points in the code the reviewer needs to double check? This entire change is a config change and a bunch of comments. ## Why was this MR needed? ``` Yorick Peterse [11:55 AM] I don't think we have any use case for nested def, might as well blacklist it Sean McGivern [11:57 AM] http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/NestedMethodDefinition Sean McGivern [11:57 AM] hmm, it's already enabled Sean McGivern [11:57 AM] ... because we exclude `db/` from rubocopDouwe Maan [11:57 AM] @smcgivern: heh Sean McGivern [11:59 AM] I guess that's because we don't want to change the old migrations? I wonder if it's worth enabling it and adding magic comments to all the previous ones to ignore rubocop Douwe Maan [11:59 AM] @smcgivern: agreed ``` ## What are the relevant issue numbers? None. ## Screenshots (if relevant) None, but if I remove the magic comment from the migration `20160416182152_convert_award_note_to_emoji_award.rb` I get: ``` $ be rubocop Inspecting 1959 files ..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: db/migrate/20160416182152_convert_award_note_to_emoji_award.rb:3:5: W: Lint/NestedMethodDefinition: Method definitions must not be nested. Use lambda instead. def up ... ^^^^^^ 1959 files inspected, 1 offense detected ``` ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - [ ] Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4559
显示
- .rubocop.yml 2 个添加, 1 个删除.rubocop.yml
- db/migrate/20121220064453_init_schema.rb 1 个添加, 0 个删除db/migrate/20121220064453_init_schema.rb
- db/migrate/20130102143055_rename_owner_to_creator_for_project.rb 1 个添加, 0 个删除...ate/20130102143055_rename_owner_to_creator_for_project.rb
- db/migrate/20130110172407_add_public_to_project.rb 1 个添加, 0 个删除db/migrate/20130110172407_add_public_to_project.rb
- db/migrate/20130123114545_add_issues_tracker_to_project.rb 1 个添加, 0 个删除db/migrate/20130123114545_add_issues_tracker_to_project.rb
- db/migrate/20130125090214_add_user_permissions.rb 1 个添加, 0 个删除db/migrate/20130125090214_add_user_permissions.rb
- db/migrate/20130131070232_remove_private_flag_from_project.rb 1 个添加, 0 个删除...igrate/20130131070232_remove_private_flag_from_project.rb
- db/migrate/20130206084024_add_description_to_namsespace.rb 1 个添加, 0 个删除db/migrate/20130206084024_add_description_to_namsespace.rb
- db/migrate/20130207104426_add_description_to_teams.rb 1 个添加, 0 个删除db/migrate/20130207104426_add_description_to_teams.rb
- db/migrate/20130211085435_add_issues_tracker_id_to_project.rb 1 个添加, 0 个删除...igrate/20130211085435_add_issues_tracker_id_to_project.rb
- db/migrate/20130214154045_rename_state_to_merge_status_in_milestone.rb 1 个添加, 0 个删除...130214154045_rename_state_to_merge_status_in_milestone.rb
- db/migrate/20130218140952_add_state_to_issue.rb 1 个添加, 0 个删除db/migrate/20130218140952_add_state_to_issue.rb
- db/migrate/20130218141038_add_state_to_merge_request.rb 1 个添加, 0 个删除db/migrate/20130218141038_add_state_to_merge_request.rb
- db/migrate/20130218141117_add_state_to_milestone.rb 1 个添加, 0 个删除db/migrate/20130218141117_add_state_to_milestone.rb
- db/migrate/20130218141258_convert_closed_to_state_in_issue.rb 1 个添加, 0 个删除...igrate/20130218141258_convert_closed_to_state_in_issue.rb
- db/migrate/20130218141327_convert_closed_to_state_in_merge_request.rb 1 个添加, 0 个删除...0130218141327_convert_closed_to_state_in_merge_request.rb
- db/migrate/20130218141344_convert_closed_to_state_in_milestone.rb 1 个添加, 0 个删除...te/20130218141344_convert_closed_to_state_in_milestone.rb
- db/migrate/20130218141444_remove_merged_from_merge_request.rb 1 个添加, 0 个删除...igrate/20130218141444_remove_merged_from_merge_request.rb
- db/migrate/20130218141507_remove_closed_from_issue.rb 1 个添加, 0 个删除db/migrate/20130218141507_remove_closed_from_issue.rb
- db/migrate/20130218141536_remove_closed_from_merge_request.rb 1 个添加, 0 个删除...igrate/20130218141536_remove_closed_from_merge_request.rb
加载中
想要评论请 注册 或 登录