Merge branch 'vij-sync-remove-ps-storage-size' into 'master'

Removes storage_size index on project statistics

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/158616



Merged-by: Alper Akgun <aakgun@gitlab.com>
Approved-by: Alper Akgun <aakgun@gitlab.com>
Reviewed-by: Alper Akgun <aakgun@gitlab.com>
Reviewed-by: Mohamed Hamda <mhamda@gitlab.com>
Co-authored-by: Vijay Hawoldar <vhawoldar@gitlab.com>

db/post_migrate/20240708121037_remove_idx_project_statistics_storage_size_and_project_id_sync.rb

+# frozen_string_literal: true
+
+class RemoveIdxProjectStatisticsStorageSizeAndProjectIdSync < Gitlab::Database::Migration[2.2]
+  milestone '17.2'
+  disable_ddl_transaction!
+
+  INDEX_NAME = 'index_project_statistics_on_storage_size_and_project_id'
+  COLUMNS = %i[storage_size project_id]
+
+  def up
+    return unless should_run?
+
+    remove_concurrent_index_by_name :project_statistics, name: INDEX_NAME
+  end
+
+  def down
+    return unless should_run?
+
+    add_concurrent_index :project_statistics, COLUMNS, name: INDEX_NAME
+  end
+
+  def should_run?
+    Gitlab.com_except_jh?
+  end
+end

db/schema_migrations/20240708121037

+9a51da84b0b6bb947fd5c0d816a71a1f0feec7d72ee60e9ea13ba7b811f27dfa
\ No newline at end of file

spec/migrations/20240611121101_remove_project_statistics_storage_size_and_project_id_index_spec.rb

@@ -4,7 +4,9 @@
 
 require_migration!
 
-RSpec.describe RemoveProjectStatisticsStorageSizeAndProjectIdIndex, feature_category: :consumables_cost_management do
+RSpec.describe RemoveProjectStatisticsStorageSizeAndProjectIdIndex,
+  feature_category: :consumables_cost_management,
+  schema: 20240611121101 do
   let(:migration) { described_class.new }
   let(:postgres_async_indexes) { table(:postgres_async_indexes) }
 

spec/migrations/20240708121037_remove_idx_project_statistics_storage_size_and_project_id_sync_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+require_migration!
+
+RSpec.describe RemoveIdxProjectStatisticsStorageSizeAndProjectIdSync,
+  feature_category: :consumables_cost_management,
+  schema: 20240708121037 do
+  let(:migration) { described_class.new }
+
+  describe '#up' do
+    it 'does nothing when not on gitlab.com' do
+      expect(migration).not_to receive(:remove_concurrent_index_by_name)
+
+      migration.up
+    end
+
+    it 'removes the index when on gitlab.com', :saas do
+      expect(migration).to receive(:remove_concurrent_index_by_name)
+
+      migration.up
+    end
+  end
+
+  describe '#down' do
+    it 'does nothing when not on gitlab.com' do
+      expect(migration).not_to receive(:add_concurrent_index)
+
+      migration.down
+    end
+
+    it 're-adds the index when on gitlab.com', :saas do
+      expect(migration).to receive(:add_concurrent_index)
+
+      migration.down
+    end
+  end
+end