ci: Fix review app deployment verification script

Signed-off-by: Rémy Coutable <remy@rymai.me>

.gitlab/ci/review-apps/main.gitlab-ci.yml

@@ -49,7 +49,6 @@ review-build-cng:
     GITLAB_REPO_URL: ${CI_PROJECT_URL}
     GITLAB_IMAGE_REPOSITORY: "registry.gitlab.com/gitlab-org/build/cng-mirror"
     GITLAB_IMAGE_SUFFIX: "ee"
-    GITLAB_VERIFY_DEPLOY_TIMEOUT_MINUTES: 5
     GITLAB_HELM_CHART_REF: "75b1486a9aec212d0f49ef1251526d8e51004bbc"  # 7.0.1: https://gitlab.com/gitlab-org/charts/gitlab/-/commit/75b1486a9aec212d0f49ef1251526d8e51004bbc
   environment:
     name: review/${CI_COMMIT_REF_SLUG}${SCHEDULE_TYPE}  # No separator for SCHEDULE_TYPE so it's compatible as before and looks nice without it

scripts/review_apps/review-apps.sh

@@ -395,8 +395,9 @@ function verify_deploy() {
 
   mkdir -p curl-logs/
 
-  local max_try_times=${GITLAB_VERIFY_DEPLOY_TIMEOUT_MINUTES} * 60 / 5
-  for i in {1..max_try_times}; do # try for GITLAB_VERIFY_DEPLOY_TIMEOUT_MINUTES minutes, default 5 minutes
+  # By default, try for 5 minutes, with 5 of sleep between attempts
+  local max_try_times=$((${GITLAB_VERIFY_DEPLOY_TIMEOUT_MINUTES:-5} * 60 / 5))
+  for i in {1..$max_try_times}; do
     local now=$(date '+%H:%M:%S')
     echo "[${now}] Verifying deployment at ${CI_ENVIRONMENT_URL}/users/sign_in"
     log_name="curl-logs/${now}.log"