Merge branch 'andrey-delete-review-scenarios' into 'master'

Remove reviewa-app related scenario and update main readme

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/147900



Merged-by: Tiffany Rea <trea@gitlab.com>
Approved-by: Tiffany Rea <trea@gitlab.com>
Co-authored-by: Andrejs Cunskis <acunskis@gitlab.com>

doc/development/testing_guide/end_to_end/index.md

@@ -160,21 +160,6 @@ so if you want to run the same tests multiple times,
 specify the same variables in each `custom-parallel` job (up to as
 many of the 10 available jobs that you want to run).
 
-#### Using the `review-qa-all` jobs
-
-On every pipeline during the `test` stage, the `review-qa-smoke` job is
-automatically started: it runs the QA smoke suite against the
-[Review App](../review_apps.md).
-
-You can also manually start the `review-qa-all`: it runs the full QA suite
-against the [Review App](../review_apps.md).
-
-**This runs end-to-end tests against a Review App based on
-[the official GitLab Helm chart](https://gitlab.com/gitlab-org/charts/gitlab/), itself deployed with custom
-[Cloud Native components](https://gitlab.com/gitlab-org/build/CNG) built from your merge request's changes.**
-
-See [Review Apps](../review_apps.md) for more details about Review Apps.
-
 #### Selective test execution
 
 In order to limit amount of tests executed in a merge request, dynamic selection of which tests to execute is present. Algorithm of which tests to run is based

qa/README.md

@@ -10,16 +10,15 @@ Tests use [GitLab QA project](https://gitlab.com/gitlab-org/gitlab-qa) for envir
 
 ## What is it?
 
-GitLab QA is an end-to-end tests suite for GitLab.
+GitLab QA is an end-to-end test framework designed for test GitLab.
 
-These are black-box and entirely click-driven end-to-end tests you can run
-against any existing instance.
+These are black-box and entirely click-driven end-to-end tests you can run against any existing instance of GitLab.
 
 ## How does it work?
 
 1. When we release a new version of GitLab, we build a Docker images for it.
 1. Along with GitLab Docker Images we also build and publish GitLab QA images.
-1. GitLab QA project uses these images to execute end-to-end tests.
+1. QA image can be used to execute e2e tests against running instance of GitLab.
 
 ## Validating GitLab views / partials / selectors in merge requests
 
@@ -45,8 +44,8 @@ Note that tests are using `Chrome` web browser by default so it should be instal
 
 Tests are executed in merge request pipelines as part of the development lifecycle.
 
-- [Review app environment](../doc/development/testing_guide/review_apps.md)
-- [e2e:package-and-test](../doc/development/testing_guide/end_to_end/index.md#testing-code-in-merge-requests)
+- [e2e:package-and-test](../doc/development/testing_guide/end_to_end/index.md#using-the-package-and-test-job)
+- [e2e:test-on-gdk](../doc/development/testing_guide/end_to_end/index.md#using-the-test-on-gdk-job)
 
 ### Including tests in other projects
 

qa/qa/scenario/test/instance/review_non_blocking.rb

-# frozen_string_literal: true
-
-module QA
-  module Scenario
-    module Test
-      module Instance
-        class ReviewNonBlocking < All
-          tags :"~reliable",
-            :"~smoke",
-            :"~skip_signup_disabled",
-            *Specs::Runner::DEFAULT_SKIPPED_TAGS.map { |tag| :"~#{tag}" }
-        end
-      end
-    end
-  end
-end