Merge branch '431302-add-method-to-rubocop' into 'master'

Adds Gitlab::Saas.enabled? to the avoid instance checks rubocop

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/136742



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Doug Stull <dstull@gitlab.com>

.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml

@@ -5,10 +5,7 @@ Gitlab/AvoidGitlabInstanceChecks:
     - 'app/controllers/admin/runners_controller.rb'
     - 'app/controllers/explore/groups_controller.rb'
     - 'app/controllers/jira_connect/oauth_application_ids_controller.rb'
-    - 'app/helpers/application_helper.rb'
     - 'app/helpers/application_settings_helper.rb'
-    - 'app/helpers/auth_helper.rb'
-    - 'app/helpers/ci/pipelines_helper.rb'
     - 'app/helpers/groups_helper.rb'
     - 'app/helpers/integrations_helper.rb'
     - 'app/helpers/packages_helper.rb'

rubocop/cop/gitlab/avoid_gitlab_instance_checks.rb

@@ -27,7 +27,7 @@ class AvoidGitlabInstanceChecks < RuboCop::Cop::Base
         MSG = 'Avoid the use of `%{name}`. Use Gitlab::Saas.feature_available?. ' \
               'See https://docs.gitlab.com/ee/development/ee_features.html#saas-only-feature'
         RESTRICT_ON_SEND = %i[
-          com? com_except_jh? com_and_canary? com_but_not_canary? org_or_com? should_check_namespace_plan?
+          com? com_except_jh? com_and_canary? com_but_not_canary? org_or_com? should_check_namespace_plan? enabled?
         ].freeze
 
         # @!method gitlab?(node)
@@ -43,8 +43,16 @@ class AvoidGitlabInstanceChecks < RuboCop::Cop::Base
                 {nil? (cbase)} :Gitlab) :CurrentSettings) :should_check_namespace_plan?)
         PATTERN
 
+        # @!method saas_enabled?(node)
+        def_node_matcher :saas_enabled?, <<~PATTERN
+          (send
+            (const
+              (const
+                {nil? (cbase)} :Gitlab) :Saas) :enabled?)
+        PATTERN
+
         def on_send(node)
-          return unless gitlab?(node) || should_check_namespace_plan?(node)
+          return unless gitlab?(node) || should_check_namespace_plan?(node) || saas_enabled?(node)
 
           add_offense(node, message: format(MSG, name: node.method_name))
         end

spec/rubocop/cop/gitlab/avoid_gitlab_instance_checks_spec.rb

@@ -18,6 +18,8 @@
         ::Gitlab.com?
         Gitlab::CurrentSettings.should_check_namespace_plan?
         ::Gitlab::CurrentSettings.should_check_namespace_plan?
+        Gitlab::Saas.enabled?
+        ::Gitlab::Saas.enabled?
       ]
     end