Improve extra_slug_path_sanitization account creation
Currently, when an account is created via oAuth (such as from BitBucket) and the `extra_slug_path_sanitization` feature is on, there is a risk of the sanitized username for the new user conflicting with an existing username. In this case, the sign-up flow will fail with the error "username is already taken." With this change, the flow will correctly iterate the username after all sanitization has finished, and create a new user with a de-conflicted name. This should ensure that even similar names from other platforms will be able to succesfully create accounts on GitLab via oAuth, SCIM, and LDAP. Changelog: fixed
显示
- ee/spec/lib/ee/gitlab/scim/group/provisioning_service_spec.rb 11 个添加, 0 个删除...pec/lib/ee/gitlab/scim/group/provisioning_service_spec.rb
- ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb 11 个添加, 0 个删除ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb
- lib/gitlab/auth/external_username_sanitizer.rb 24 个添加, 5 个删除lib/gitlab/auth/external_username_sanitizer.rb
- spec/lib/gitlab/auth/external_username_sanitizer_spec.rb 13 个添加, 0 个删除spec/lib/gitlab/auth/external_username_sanitizer_spec.rb
- spec/lib/gitlab/auth/o_auth/user_spec.rb 7 个添加, 0 个删除spec/lib/gitlab/auth/o_auth/user_spec.rb
加载中
想要评论请 注册 或 登录