Merge branch 'show-pa-toggle-root' into 'master'

Hide product analytics checkbox unless root

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138486



Merged-by: Jiaan Louw <3468028-jiaan@users.noreply.gitlab.com>
Approved-by: Max Woolf <mwoolf@gitlab.com>
Approved-by: Rutger Wessels <rwessels@gitlab.com>
Approved-by: Jiaan Louw <3468028-jiaan@users.noreply.gitlab.com>
Reviewed-by: Max Woolf <mwoolf@gitlab.com>
Reviewed-by: Rutger Wessels <rwessels@gitlab.com>
Co-authored-by: Rutger Wessels <rwessels@gitlab.com>
Co-authored-by: Halil Coban <hcoban@gitlab.com>

ee/app/controllers/ee/groups_controller.rb

@@ -101,8 +101,11 @@ def group_params_ee
         params_ee << :enforce_ssh_certificates if current_group&.ssh_certificates_available?
         params_ee << :code_suggestions if ai_assist_ui_enabled?
         params_ee << { value_stream_dashboard_aggregation_attributes: [:enabled] } if can?(current_user, :modify_value_stream_dashboard_settings, current_group)
-        params_ee << :product_analytics_enabled
-        params_ee << :experiment_features_enabled if experiment_settings_allowed?
+
+        if experiment_settings_allowed?
+          params_ee << :product_analytics_enabled
+          params_ee << :experiment_features_enabled
+        end
       end
     end
 

ee/app/views/groups/settings/_product_analytics_settings.html.haml

+- return unless group.experiment_settings_allowed?
+
 - learn_more = help_page_path('user/product_analytics/index')
 %h5
   = s_('ProductAnalytics|Product Analytics')

ee/spec/views/groups/settings/_permissions.html.haml_spec.rb

@@ -61,4 +61,35 @@
       end
     end
   end
+
+  context 'for product analytics settings' do
+    before do
+      allow(view).to receive(:ai_assist_ui_enabled?).and_return(true)
+      allow(group).to receive(:licensed_feature_available?).and_call_original
+      allow(group).to receive(:licensed_feature_available?).with(:experimental_features).and_return(true)
+      allow(Gitlab::CurrentSettings).to receive(:should_check_namespace_plan?).and_return(true)
+    end
+
+    context 'as a sub-group' do
+      it 'renders nothing' do
+        allow(group).to receive(:root?).and_return(false)
+
+        render
+
+        expect(rendered).to render_template('groups/settings/_product_analytics_settings')
+        expect(rendered).not_to have_content(_('Product Analytics'))
+      end
+    end
+
+    context 'as a root group' do
+      it 'renders the product analytics settings' do
+        allow(group).to receive(:root?).and_return(true)
+
+        render
+
+        expect(rendered).to render_template('groups/settings/_product_analytics_settings')
+        expect(rendered).to have_content(_('Product Analytics'))
+      end
+    end
+  end
 end