Skip to content
代码片段 群组 项目
  • Lukas Eipert's avatar
    8100039a
    Remove broken SCSS rule · 8100039a
    Lukas Eipert 创作于
    When working on the new CSS compiler, we found this broken SCSS rule,
    which simplified looks like this:
    ```scss
    .class::before {
      &.other-class {
        top: 30px;
      }
    }
    ```
    
    It currently compiles to `.class.other-class::before`. In the new SASS
    compiler, it compiles to `.class::before.other-class` which is invalid.
    It's really confusing why this works _currently_, and it's the only
    of this in our code base.
    
    Luckily for us, the rule seems obsolete (I suspect that something in
    https://gitlab.com/gitlab-org/gitlab/-/merge_requests/135038 might have
    fixed it).
    8100039a
    历史
    Remove broken SCSS rule
    Lukas Eipert 创作于
    When working on the new CSS compiler, we found this broken SCSS rule,
    which simplified looks like this:
    ```scss
    .class::before {
      &.other-class {
        top: 30px;
      }
    }
    ```
    
    It currently compiles to `.class.other-class::before`. In the new SASS
    compiler, it compiles to `.class::before.other-class` which is invalid.
    It's really confusing why this works _currently_, and it's the only
    of this in our code base.
    
    Luckily for us, the rule seems obsolete (I suspect that something in
    https://gitlab.com/gitlab-org/gitlab/-/merge_requests/135038 might have
    fixed it).
代码所有者
将用户和群组指定为特定文件更改的核准人。 了解更多。
notes.scss 20.97 KiB