Skip to content
代码片段 群组 项目
  • Mark Florian's avatar
    2d29ad27
    Fix math block alert rendering · 2d29ad27
    Mark Florian 创作于
    This replaces the static markup to recreate an alert with a real
    `GlAlert` instance for maths blocks. This fixes incorrect styling of the
    alert, incorrect positioning of the `<copy-code>` element, and also
    simplifies wiring up of events.
    
    Before, the `<copy-code>` button was displaying over the alert's dismiss
    button. Now, it correctly displays within the maths code block it's
    associated with.
    
    Since `<copy-code>` is absolutely positioned, and its nearest positioned
    ancestor is the `.js-markdown-code` element, and the alert was the first
    child of that element, the `<copy-code>` button was rendered over the
    alert instead of the code block below.
    
    Now, the alert is the immediate previous sibling of the
    `.js-markdown-code` element, instead of its first child.
    
    Addresses https://gitlab.com/gitlab-org/gitlab/-/issues/455642 and
    https://gitlab.com/gitlab-org/gitlab/-/issues/455665.
    
    Changelog: fixed
    未验证
    2d29ad27
    历史
    Fix math block alert rendering
    Mark Florian 创作于
    This replaces the static markup to recreate an alert with a real
    `GlAlert` instance for maths blocks. This fixes incorrect styling of the
    alert, incorrect positioning of the `<copy-code>` element, and also
    simplifies wiring up of events.
    
    Before, the `<copy-code>` button was displaying over the alert's dismiss
    button. Now, it correctly displays within the maths code block it's
    associated with.
    
    Since `<copy-code>` is absolutely positioned, and its nearest positioned
    ancestor is the `.js-markdown-code` element, and the alert was the first
    child of that element, the `<copy-code>` button was rendered over the
    alert instead of the code block below.
    
    Now, the alert is the immediate previous sibling of the
    `.js-markdown-code` element, instead of its first child.
    
    Addresses https://gitlab.com/gitlab-org/gitlab/-/issues/455642 and
    https://gitlab.com/gitlab-org/gitlab/-/issues/455665.
    
    Changelog: fixed
代码所有者
将用户和群组指定为特定文件更改的核准人。 了解更多。
gitlab.pot 1.38 MiB