spec/controllers/dashboard_controller_spec.rb · 1b9dbdc99817b0dc7a516fcf46c1bf9b18e0b539 · gitlab-cn / GitLab

3 years ago

Fix filters presence check to take value into consideration · 1b9dbdc9

由 Patrick Bajao 创作于 3 years ago

This fixes a bug in the issues/MRs dashboard filter check which
allows filtering by empty value. It can result to SQL statement
timeout.

The fix is to check if the value of the filter is present. If not,
the dashboard will show the "Please select at least one filter to
see results" message.

Changelog: fixed

1b9dbdc9

历史

Fix filters presence check to take value into consideration

由 Patrick Bajao 创作于 3 years ago

This fixes a bug in the issues/MRs dashboard filter check which
allows filtering by empty value. It can result to SQL statement
timeout.

The fix is to check if the value of the filter is present. If not,
the dashboard will show the "Please select at least one filter to
see results" message.

Changelog: fixed

代码所有者

将用户和群组指定为特定文件更改的核准人。了解更多。