app/controllers/dashboard_controller.rb · 138f3d1a76ab05f9e73db667eafd3e94bbe70e19 · gitlab-cn / GitLab

3 years ago

Don't allow filtering by `in` alone on issue/MR dashboard · 138f3d1a

由 Patrick Bajao 创作于 3 years ago

When `in` param is set while no `search` param is set, the issues
and MRs finder won't use the `in` param. It'll instead skip the
filter check and can result to SQL statement timeout.

The fix is to check that if `in` param is set but no search, show
the "Please select at least one filter to see results" message.

Changelog: fixed

138f3d1a

历史

Don't allow filtering by `in` alone on issue/MR dashboard

由 Patrick Bajao 创作于 3 years ago

When `in` param is set while no `search` param is set, the issues
and MRs finder won't use the `in` param. It'll instead skip the
filter check and can result to SQL statement timeout.

The fix is to check that if `in` param is set but no search, show
the "Please select at least one filter to see results" message.

Changelog: fixed

代码所有者

将用户和群组指定为特定文件更改的核准人。了解更多。