Skip to content
代码片段 群组 项目
  • Vasilii Iakliushin's avatar
    fef6c679
    Fix: admin group update logic · fef6c679
    Vasilii Iakliushin 创作于
    Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/423509
    
    **Problem**
    
    The logic to convert repository size limit is defined on controller
    level and service level. It leads to a double convertion problem.
    Controller converts megabytes to bytes and then service repeats the
    process.
    
    However, it's broken only for create group flow. Because the update
    group doesn't use a service.
    
    **Solution**
    
    * Use `Groups::UpdateService` to update groups from Admin area
    * Remove byte convertion logic from controller
    
    Changelog: fixed
    EE: true
    fef6c679
    历史
    Fix: admin group update logic
    Vasilii Iakliushin 创作于
    Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/423509
    
    **Problem**
    
    The logic to convert repository size limit is defined on controller
    level and service level. It leads to a double convertion problem.
    Controller converts megabytes to bytes and then service repeats the
    process.
    
    However, it's broken only for create group flow. Because the update
    group doesn't use a service.
    
    **Solution**
    
    * Use `Groups::UpdateService` to update groups from Admin area
    * Remove byte convertion logic from controller
    
    Changelog: fixed
    EE: true
代码所有者
将用户和群组指定为特定文件更改的核准人。 了解更多。