Clean up CI for cypress (#661)

* Remove some pointles wording from the test file.

* Upgrade cypress ubuntu to 22.04

* Add windows to cypress matrix.

* Change matrices for everything, because ubuntu 18 is becoming obsolete.

* Can not use windows until the scripts are fixed. Stupid.

* Condition Linux commands to linux.

* Add back the windows runners.

* Remove windows from OS matrix.

.github/workflows/cypress.yml

 # This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
 # For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
 
-name: Cypress UI tests
+name: Cypress UI tests - Zigbee data
 
 on:
   push:
@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         node-version: [16.x]
-        os: [ubuntu-18.04]
+        os: [ubuntu-22.04]
 
     steps:
       - uses: actions/checkout@v2
@@ -26,10 +26,13 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
       - run: sudo ./src-script/install-packages-ubuntu
+        if: startsWith(matrix.os, 'ubuntu')
       - run: sudo apt-get install --fix-missing xvfb
+        if: startsWith(matrix.os, 'ubuntu')
       - run: npm ci
       - run: npm run version-stamp
       - run: npm rebuild canvas --update-binary
       - run: npm rebuild libxmljs --update-binary
       - run: npm run build-spa
       - run: xvfb-run -a npm run test:e2e-ci
+        if: startsWith(matrix.os, 'ubuntu')

.github/workflows/mattercypress.yml

 # This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
 # For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
 
-name: Cypress UI tests against matter data
+name: Cypress UI tests - Matter data
 
 on:
   push:
@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         node-version: [16.x]
-        os: [ubuntu-latest, ubuntu-18.04]
+        os: [ubuntu-22.04]
 
     steps:
       - uses: actions/checkout@v2
@@ -26,10 +26,13 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
       - run: sudo ./src-script/install-packages-ubuntu
+        if: startsWith(matrix.os, 'ubuntu')
       - run: sudo apt-get install --fix-missing xvfb
+        if: startsWith(matrix.os, 'ubuntu')
       - run: npm ci
       - run: npm run version-stamp
       - run: npm rebuild canvas --update-binary
       - run: npm rebuild libxmljs --update-binary
       - run: npm run build-spa
       - run: xvfb-run -a npm run test:e2e-matter-ci
+        if: startsWith(matrix.os, 'ubuntu')

.github/workflows/sonarcloud.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, ubuntu-18.04]
+        os: [ubuntu-latest]
 
     steps:
       - uses: actions/checkout@v2

.github/workflows/zap.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       matrix:
         node-version: [16.x]
-        os: [ubuntu-latest, ubuntu-18.04]
+        os: [ubuntu-latest]
 
     steps:
       - uses: actions/checkout@v2

test/gen-template/matter3/6.zapt

-/*
- *
- *    Copyright (c) 2022 Project CHIP Authors
- *    All rights reserved.
- *
- *    Licensed under the Apache License, Version 2.0 (the "License");
- *    you may not use this file except in compliance with the License.
- *    You may obtain a copy of the License at
- *
- *        http://www.apache.org/licenses/LICENSE-2.0
- *
- *    Unless required by applicable law or agreed to in writing, software
- *    distributed under the License is distributed on an "AS IS" BASIS,
- *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *    See the License for the specific language governing permissions and
- *    limitations under the License.
- */
-
-#include <controller/java/CHIPAttributeTLVValueDecoder.h>
-
-#include <app/data-model/Decode.h>
-#include <app/data-model/DecodableList.h>
-#include <app-common/zap-generated/cluster-objects.h>
-#include <app-common/zap-generated/ids/Events.h>
-#include <app-common/zap-generated/ids/Clusters.h>
-#include <jni.h>
-#include <lib/support/JniReferences.h>
-#include <lib/support/JniTypeWrappers.h>
-#include <lib/support/TypeTraits.h>
-
-namespace chip {
 
 jobject DecodeEventValue(const app::ConcreteEventPath & aPath, TLV::TLVReader & aReader, CHIP_ERROR * aError)
 {