Skip to content
代码片段 群组 项目
未验证 提交 e35c4a8a 编辑于 作者: Chris Ross's avatar Chris Ross 提交者: GitHub
浏览文件

Apply suggestions from code review

上级 ac6b62b5
No related branches found
No related tags found
无相关合并请求
...@@ -126,10 +126,10 @@ ...@@ -126,10 +126,10 @@
<RuntimeInstallerBaseName>aspnetcore-runtime</RuntimeInstallerBaseName> <RuntimeInstallerBaseName>aspnetcore-runtime</RuntimeInstallerBaseName>
<TargetingPackInstallerBaseName>aspnetcore-targeting-pack</TargetingPackInstallerBaseName> <TargetingPackInstallerBaseName>aspnetcore-targeting-pack</TargetingPackInstallerBaseName>
<!-- This is used to produce targeting pack installers/packages once per major.minor except in extraordinary cases i.e. 3.1.8. --> <!-- This is used to produce targeting pack installers/packages once per major.minor. -->
<IsTargetingPackBuilding Condition=" '$(DotNetBuildFromSource)' == 'true' ">false</IsTargetingPackBuilding> <IsTargetingPackBuilding Condition=" '$(DotNetBuildFromSource)' == 'true' ">false</IsTargetingPackBuilding>
<IsTargetingPackBuilding <IsTargetingPackBuilding
Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(AspNetCorePatchVersion)' != '8' ">false</IsTargetingPackBuilding> Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(AspNetCorePatchVersion)' != '0' ">false</IsTargetingPackBuilding>
<IsTargetingPackBuilding Condition=" '$(IsTargetingPackBuilding)' == '' ">true</IsTargetingPackBuilding> <IsTargetingPackBuilding Condition=" '$(IsTargetingPackBuilding)' == '' ">true</IsTargetingPackBuilding>
<!-- <!--
......
...@@ -31,12 +31,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests ...@@ -31,12 +31,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
private async Task<bool> HostNameIsReachable() private async Task<bool> HostNameIsReachable()
{ {
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
{
// Code below is unreliable on macOS and tests fail on that platform.
return false;
}
try try
{ {
_hostname = Dns.GetHostName(); _hostname = Dns.GetHostName();
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册