Quarantine test and fix up conditional check (#34904)

* Update condition check for Visual Studio

* QT Http3TimeoutTests failure

* Fix version check condition

* Add ref comment and clean up code

Directory.Build.props

@@ -15,7 +15,8 @@
     <AnalysisMode>Default</AnalysisMode>
   </PropertyGroup>
 
-  <PropertyGroup Condition=" '$(BuildingInsideVisualStudio)' == 'true' AND '$(VisualStudioVersion)' == '17.0' ">
+  <!-- See https://github.com/dotnet/roslyn/issues/54867 for more info. -->
+  <PropertyGroup Condition="'$(BuildingInsideVisualStudio)' == 'true' AND $([MSBuild]::VersionGreaterThanOrEquals('$(VisualStudioVersion)', '17.0'))">
     <RunAnalyzersDuringBuild>false</RunAnalyzersDuringBuild>
     <RunAnalyzersDuringLiveAnalysis>false</RunAnalyzersDuringLiveAnalysis>
     <RunAnalyzers>false</RunAnalyzers>

eng/targets/CSharp.Common.targets

@@ -20,7 +20,7 @@
         '$(IsImplementationProject)' == 'true' OR
         '$(IsAnalyzersProject)' == true OR
         '$(IsSpecificationTestProject)' == 'true') ">enable</Nullable>
-    
+
     <!-- Strip out non-public nullable annotations for src projects. This should help with size reduction -->
      <Features Condition="
         '$(IsImplementationProject)' == 'true' OR
@@ -36,7 +36,8 @@
 
     <!-- Enable .NET code style analysis during build for src projects. -->
     <!-- Workaround bug where turning this on produces warnings in VS -->
-    <EnforceCodeStyleInBuild Condition="'$(BuildingInsideVisualStudio)' == 'true' AND '$(VisualStudioVersion)' &lt; '17.0'">false</EnforceCodeStyleInBuild>
+    <!-- See https://github.com/dotnet/roslyn/issues/54867 for more info. -->
+    <EnforceCodeStyleInBuild Condition="'$(BuildingInsideVisualStudio)' == 'true' AND $([MSBuild]::VersionGreaterThanOrEquals('$(VisualStudioVersion)', '17.0'))">false</EnforceCodeStyleInBuild>
     <EnforceCodeStyleInBuild Condition="'$(EnforceCodeStyleInBuild)' == ''">true</EnforceCodeStyleInBuild>
   </PropertyGroup>
 

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http3/Http3TimeoutTests.cs

@@ -486,6 +486,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
         }
 
         [Fact]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34903")]
         public async Task DATA_Received_TooSlowlyOnSecondStream_AbortsConnectionAfterNonAdditiveRateTimeout()
         {
             var mockSystemClock = _serviceContext.MockSystemClock;