Skip to content
代码片段 群组 项目
  1. 10月 12, 2022
  2. 10月 11, 2022
  3. 10月 10, 2022
    • ConfluentSemaphore's avatar
    • Colin Patrick McCabe's avatar
      MINOR: fix indentation and add builders in some KRaft tests (#12720) · bee53e7b
      Colin Patrick McCabe 创作于
      Add builders for LocalLogManagerTestEnv and QuorumControllerTestEnv, since the constructor
      overloads were starting to get unwieldy.
      
      Make indentation more consistent in QuorumControllerTest. Take advantage of the fact that you can
      initialize multiple resources in a Java try-with-resources block to avoid excessive indentation in a few
      cases.
      
      Reviewers: José Armando García Sancio <jsancio@apache.org>
      Conflicts: Fix some conflicts in QuorumControllerTest related to ce-only features.
      bee53e7b
    • José Armando García Sancio's avatar
      MINOR; Fix error message when validating KRaft config (#12717) · 33630119
      José Armando García Sancio 创作于
      The error message reported when advertised.listeners is used in
      controller only is confusing. When the KRaft server is configured to
      controller only the following must be true:
      
      1. `advertised.listeners` is not set
      2. `listeners` contains a listener for every name in `controller.listener.names`
      3. `controller.listener.names` contains a name for every listener in `listeners`
      
      Reviewers: Jason Gustafson <jason@confluent.io>, Igor Soarez <i@soarez.me>
      Conflicts: In KafkaConfigTest, ce-kafka was using Properties#put, whereas AK was using
          Properties#setProperty. This PR resolves that divergence by simply using setProperty
          everywhere. The use of Properties#put is "strongly discouraged" according to the Java
          documentation because it can compromise type safety.
      
          Also in KafkaConfigTest, ce-kafka was explicitly disabling cluster linking since that used to
          be incompatible with KRaft. It isn't any more, so this PR drops that divergence as well.
      33630119
  4. 10月 09, 2022
  5. 10月 08, 2022
  6. 10月 07, 2022
加载中