- 7月 03, 2020
-
-
由 Harini Rajendran 创作于
[METRICS-1844, METRICS-1839, METRICS-1756] - Reconcile configs in Telemetry Reporter before creating a ConfluentTelemetryConfig object. Use password object for api.secret in ConfluentTelemetryConfig.java. (#2125)
- 7月 02, 2020
-
-
由 Tim Fox 创作于
-
由 Sumit Arrawatia 创作于
-
由 Steve Rodrigues 创作于
[CNKAF-885, CNKAF-946, CNKAF-947] Set SBK Default Throttle, handle absent brokers when setting throttle. (#2119) * [CNKAF-885] Ensure that the default ConfluentConfigs throttle value goes through to CruiseControl. * [CNKAF-946] Treat a throttle value of NO_THROTTLE as disabled (previously treated as invalid). * [CNKAF-947]: Allow setting replication throttle when some brokers are offline. Due to the way the ReplicationThrottleHelper worked, it would not be able to set replication throttles for brokers (X,Y,Z) if any subset of the brokers were offline. This is because we describe the configs for each broker in order to know whether they have statically-set replication throttles, which allows SBK to conditionally override them depending on a configurable variable. This patch changes the overrides and config describes to be best effort - that is, if the config describe for a given broker fails, we continue with setting replication throttles for it (via ZK) and the rest of the brokers. Any static throttles on said offline broker would always get overridden, as we do not have the broker configs handy to know whether we are overriding or not. In practice, this should not be an issue since the broker is offline regardless and the configs get cleaned up afterwards * Fix tests: integration tests, and unit tests due to different API calls (fix up mocks). Ensure that throttle is set for RemoveBrokerTest to avoid a reprise of CNKAF-947. * Rename DEFAULT_REPLICATION_THROTTLE_CONFIG property, include doc for disabling throttling. Co-authored-by: Stanislav Kozlovski <stanislav_kozlovski@outlook.com>
-
由 Brian Bushree 创作于
-
由 Xavier Léauté 创作于
Some projects directly depend on confluent-serializers at compile time, but also need confluent-metrics at runtime. This ensures the confluent-serializers classes included in the confluent-metrics fat jar do not clash with confluent-serializers classes independently pulled into the classpath. Additionally, since we shade some protobuf and guava dependencies for confluent-serializers and confluent-licensing as part of ce-broker-plugins, we also need to do the same in ce-sbk to avoid ending up with the two versions of the confluent-serializers classes with protobuf shaded differently on the broker classpath.
- 7月 01, 2020
-
-
由 Leonard Ge 创作于
Added SNI host name validation for `FileBasedPlainSaslAuthenticator`. There are three modes for this authentication: - optional_validation: clusters that uses the v3 CCloud Network architecture Validate the hostname only if a lkc prefixed hostname is provided. If not present, let it pass. - allow_legacy_bootstrap: v4 network architecture with legacy bootstrap (before all customers have changed their bootstrap configs) Validate lkc-prefixed host names and let pkc-prefixed host names pass. The latter is used for the bootstrapping path and we rely on an external proxy (e.g Envoy) to enforce the SNI hostname is lkc-prefixed when connecting directly to the broker (i.e not bootstrapping). - strict: clusters that uses the v4 CCloud Network architecture Requires SNI for both bootstrap and broker path. Also refactored the existing implementation as well as added tests for the new features. The mode will be passed in as: confluent.multitenant.listener.prefix.enable=false listener.name.external.plain.sasl.jaas.config=io.confluent.kafka.server.plugins.auth.FileBasedLoginModule required \ username="caas" \ password="caas-secret" \ config_path="/mnt/secrets/apikeys.json" \ refresh_ms="30000" \ validate_sni=optional_validation / allow_legacy_bootstrap / strict;
-
由 Rohit Shekhar 创作于
reviewers @junrao & @mattwong949
-
由 Xavier Léauté 创作于
- 6月 30, 2020
-
-
由 Leonard Ge 创作于
* Implemented the expansion of the logical cluster. * Some refactoring. * Fixed stale comment. * Refactored according to comments. * Make variable private. * Addressed reviewer comments. * Improved efficiency of the code. * Renaming a helper function. * Added new configuration to turn on and off of the LKC prepending to the hostname, this should improve performance. * Moved tenant metric out from config class. * Fixed benchmarking code. * Removed unused import. * Remove setters. * Fixed nits. * Fixed benchmarking error. * Removed unused import. * Addressed reviewer comments. * Fixed nits. * Added parameters for benchmark. * Fixed more nits. * Fixed unused import.
-
由 Xavier Léauté 创作于
use balancer config if available to set telemetry local topic replication factor Co-authored-by: Brian Bushree <bbushree@confluent.io>
-
由 Ismael Juma 创作于
We updated the interceptor to allow setting this config, but it is not a dynamic config. The fix is simple: 1. Change KafkaConfig.numPartitions from a val to a def 2. Add it to `DynamicBrokerConfig.AllDynamicConfigs` Reviewers: Agam Brahma <abrahma+git@confluent.io>
-
由 Vikas Singh 创作于
When we check for topics needed by SBK to become available, we may encounter transient errors. These errors are currently reported using throwing/catching exception. Logging those create noise in the log. Just printing the error message and retrying is better. This change updates the error handling to log message at info level and skip throwing exception. If the unlikely case an exception is thrown because of a real non-transient error, the exception is continued to be logged at ERROR level.
-
由 Brian Bushree 创作于
-
由 Brian Bushree 创作于
- 6月 27, 2020
-
-
由 Steve Rodrigues 创作于
-
由 Sanjana Kaundinya 创作于
-
由 David Mao 创作于
CNKAF-918: Relax GoalUtils.eligibleBrokers criteria to allow leadership movements off observers. (#2075) * Adds integration test for interaction between AddBroker and Replica Placement * Relax leadership movement requirements when there are brokers in New state
-
由 Alex Cheng 创作于
* CIAM-109 Add authCache API to fetch role bindings for multiple scopes
-
由 Steve Rodrigues 创作于
Self-Balancing Kafka (the DataBalancer) used to base the RF of its internal topics on that of the (publicly configured) ConfluentMetricsReporter but has since switched to the TelemetryMetricsReporter, which is automatically configured. Instead, do not rely on the Telemetry Metrics RF [CNKAF-924]. This exposed a bug in how the SBK RF was read and propagated [CNKAF-926], so correct that. To prevent a repeat of CNKAF-926, rename the SBK *_BASE_CONFIG config variables to *_SBK_CONFIG. As these are the names of the config values as they should be accessed from within SBK, this name is hopefully less confusing. Uncomment the balancer replication factor=1 config in config/server.properties for better OOBE in development setups.