Correctness and tidy

Test compilation performed with warnings. Author and license added. Test for failing grep on ancient OSX versions. Replaced the test image with something less noisy (which compresses better).

contrib/single_file_decoder/README.md

@@ -12,7 +12,7 @@ Then add the resulting file to your project (see the [example files](examples)).
 `create_single_file_decoder.sh` will run the above script, creating file `zstddeclib.c`.
 `build_test.sh` will create the decoder, then compile and test the library.
 
-Why
----
+Why?
+----
 
-Because all it now takes to support decompressing Zstd is the addition of a single file, two if using the header, with no configuration or further build steps. The library is small, adding, for example, 25kB to an Emscripten compiled WebAssembly project. Native implementations add a little more, 40-70kB depending on the compiler and platform.
+Because all it now takes to support decompressing Zstd is the addition of a single file, two if using the header, with no configuration or further build steps. The library is small, adding, for example, 26kB to an Emscripten compiled WebAssembly project. Native implementations add a little more, 40-70kB depending on the compiler and platform.

contrib/single_file_decoder/build_test.sh

@@ -19,7 +19,7 @@ fi
 echo "Single file decoder creation script: PASSED"
 
 # Compile the generated output
-cc -Os -g0 -o $OUT_FILE examples/simple.c
+cc -Wall -Wextra -Werror -Os -g0 -o $OUT_FILE examples/simple.c
 # Did compilation work?
 if [ $? -ne 0 ]; then
   echo "Compiling simple.c: FAILED"
@@ -44,7 +44,7 @@ if [ $? -ne 0 ]; then
   echo "(Skipping Emscripten test)"
 else
   # Compile the Emscripten example
-  CC_FLAGS="-Wall -Wextra -Os -g0 -flto --llvm-lto 3 -lGL -DNDEBUG=1"
+  CC_FLAGS="-Wall -Wextra -Werror -Os -g0 -flto --llvm-lto 3 -lGL -DNDEBUG=1"
   emcc $CC_FLAGS -s WASM=1 -o $OUT_WASM examples/emscripten.c
   # Did compilation work?
   if [ $? -ne 0 ]; then

contrib/single_file_decoder/combine.sh

@@ -6,6 +6,8 @@
 # implementation (due to the grep calls) but it runs and works everywhere.
 # 
 # TODO: ROOTS and FOUND as arrays (since they fail on paths with spaces)
+# 
+# Author: Carl Woffenden, Numfum GmbH (released under a CC0 license)
 
 # Common file roots
 ROOTS="./"
@@ -25,6 +27,14 @@ usage() {
   exit 1
 }
 
+# Tests that the grep implementation works as expected (older OSX grep fails)
+test_grep() {
+	if ! echo '#include "foo"' | grep -Eq '^\s*#\s*include\s*".+"'; then
+		echo "Aborting: the grep implementation fails to parse include lines"
+		exit 1
+	fi
+}
+
 # Tests if list $1 has item $2 (returning zero on a match)
 list_has_item() {
   if echo "$1" | grep -Eq "(^|\s*)$2(\$|\s*)"; then
@@ -102,6 +112,7 @@ if [ -n "$1" ]; then
     if [ -n "$DESTN" ]; then
       printf "" > "$DESTN"
     fi
+    test_grep
     add_file $1
   else
     echo "Input file not found: \"$1\""

contrib/single_file_decoder/examples/README.md

@@ -4,4 +4,6 @@ The examples `#include` the generated `zstddeclib.c` directly but work equally a
 
 `simple.c` is the most basic example of decompressing content and verifying the result.
 
-`emscripten.c` is a bare-bones [Emscripten](https://github.com/emscripten-core/emscripten) compiled WebGL demo using Zstd to further compress a DXT1 texture. The 256x256 texture would normally be 32kB, but even when bundled with the Zstd decompressor the resulting WebAssembly weighs in at 45kB (`shell.html` is a support file to run the Wasm).
+`emscripten.c` is a bare-bones [Emscripten](https://github.com/emscripten-core/emscripten) compiled WebGL demo using Zstd to further compress a DXT1 texture (see the [original PNG image](testcard.png)). The 256x256 texture would normally be 32kB, but even when bundled with the Zstd decompressor the resulting WebAssembly weighs in at 41kB (`shell.html` is a support file to run the Wasm).
+
+The example files in this directory are released under a [Creative Commons Zero license](https://creativecommons.org/publicdomain/zero/1.0/).