Skip to content
代码片段 群组 项目
提交 ff82e62a 编辑于 作者: Malcolm Locke's avatar Malcolm Locke 提交者: Luke Duncalfe
浏览文件

Remove unneeded :expected_type overrides

This use of an :expected_type check is no longer required so these
mutations do not need to override the base class implementation of
`find_object`.

The `:expected_type` checks date back to when ids were all represented
by a single generic `ID` type.  This has been replaced with specific
types of the form `GlobalIdType[::Project]`, `GlobalIdType[::Issue]`,
etc.

These specific types handle the type checking when the GID object is
parsed.  When an argument is defined as `GlobalIdType[::Project]`
passing a GID like `gid://gitlab/Issue/1` will fail before the
`:expected_type` check is ever performed.

See https://gitlab.com/gitlab-org/gitlab/-/issues/257883 for more
context.
上级 f4095e90
No related branches found
No related tags found
无相关合并请求
显示
3 个添加75 个删除
加载中
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册