Merge branch 'sh-update-sidekiq-reliable-fetch-timeout' into 'master'

Increase DEFAULT_SEMI_RELIABLE_FETCH_TIMEOUT to 5 seconds

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/139583



Merged-by: Heinrich Lee Yu <heinrich@gitlab.com>
Approved-by: Heinrich Lee Yu <heinrich@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

vendor/gems/sidekiq-reliable-fetch/lib/sidekiq/semi_reliable_fetch.rb

@@ -5,7 +5,7 @@ class SemiReliableFetch < BaseReliableFetch
     # We want the fetch operation to timeout every few seconds so the thread
     # can check if the process is shutting down. This constant is only used
     # for semi-reliable fetch.
-    DEFAULT_SEMI_RELIABLE_FETCH_TIMEOUT = 2 # seconds
+    DEFAULT_SEMI_RELIABLE_FETCH_TIMEOUT = 5 # seconds
 
     def initialize(options)
       super

vendor/gems/sidekiq-reliable-fetch/spec/semi_reliable_fetch_spec.rb

@@ -21,7 +21,7 @@
 
         it 'brpops with the default timeout timeout' do
           Sidekiq.redis do |connection|
-            expect(connection).to receive(:brpop).with("queue:stuff_to_do", { timeout: 2 }).once.and_call_original
+            expect(connection).to receive(:brpop).with("queue:stuff_to_do", { timeout: 5 }).once.and_call_original
 
             fetcher.retrieve_work
           end
@@ -29,11 +29,11 @@
       end
 
       context 'when the timeout is set in the env' do
-        let(:timeout) { '5' }
+        let(:timeout) { '6' }
 
         it 'brpops with the default timeout timeout' do
           Sidekiq.redis do |connection|
-            expect(connection).to receive(:brpop).with("queue:stuff_to_do", { timeout: 5 }).once.and_call_original
+            expect(connection).to receive(:brpop).with("queue:stuff_to_do", { timeout: 6 }).once.and_call_original
 
             fetcher.retrieve_work
           end