Merge branch '434219-add-allow-anonymous-searches-ff' into 'master'

Add allow_anonymous_searches feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138975



Merged-by: Terri Chu <tchu@gitlab.com>
Approved-by: Ravi Kumar <rkumar@gitlab.com>
Approved-by: Terri Chu <tchu@gitlab.com>
Reviewed-by: Terri Chu <tchu@gitlab.com>
Co-authored-by: Dmitry Gruzd <dgruzd@gitlab.com>

app/controllers/search_controller.rb

@@ -27,7 +27,10 @@ def self.search_rate_limited_endpoints
 
   around_action :allow_gitaly_ref_name_caching
 
-  before_action :block_anonymous_global_searches, :check_scope_global_search_enabled, except: :opensearch
+  before_action :block_all_anonymous_searches,
+    :block_anonymous_global_searches,
+    :check_scope_global_search_enabled,
+    except: :opensearch
   skip_before_action :authenticate_user!
 
   requires_cross_project_access if: -> do
@@ -226,6 +229,14 @@ def block_anonymous_global_searches
     redirect_to new_user_session_path, alert: _('You must be logged in to search across all of GitLab')
   end
 
+  def block_all_anonymous_searches
+    return if current_user || ::Feature.enabled?(:allow_anonymous_searches, type: :ops)
+
+    store_location_for(:user, request.fullpath)
+
+    redirect_to new_user_session_path, alert: _('You must be logged in to search')
+  end
+
   def check_scope_global_search_enabled
     return unless search_service.global_search?
 

config/feature_flags/ops/allow_anonymous_searches.yml

+---
+name: allow_anonymous_searches
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138975
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/434218
+milestone: '16.7'
+type: ops
+group: group::global search
+default_enabled: true

locale/gitlab.pot

@@ -55983,6 +55983,9 @@ msgstr ""
 msgid "You must be authenticated to access this path."
 msgstr ""
+msgid "You must be logged in to search"
+msgstr ""
+
 msgid "You must be logged in to search across all of GitLab"
 msgstr ""

spec/controllers/search_controller_spec.rb

@@ -189,6 +189,25 @@
           end
         end
 
+        context 'when allow_anonymous_searches is disabled' do
+          before do
+            stub_feature_flags(allow_anonymous_searches: false)
+          end
+
+          context 'for unauthenticated user' do
+            before do
+              sign_out(user)
+            end
+
+            it 'redirects to login page' do
+              get :show, params: { scope: 'projects', search: '*' }
+
+              expect(response).to redirect_to new_user_session_path
+              expect(flash[:alert]).to match(/You must be logged in/)
+            end
+          end
+        end
+
         context 'tab feature flags' do
           subject { get :show, params: { scope: scope, search: 'term' }, format: :html }