Add parent label failed
In the MR: gitlab-cn/gitlab!747 (merged), I added the label ~"feature::enhancement"
, the processor AddParentLabel
doesn't seem to work.
Production logs
{"name":"rack","hostname":"triage-web-deployment-798779d4d-dkqg5","pid":6,"severity":"INFO","time":"2022-08-03T03:58:18.274+00:00","message":"Event processing","dry_run":false,"event_class":"Triage::MergeRequestEvent","event_key":"merge_request.update","event_payload":{"object_kind":"merge_request","event_type":"merge_request","user":{"id":4000,"name":"Song Huang","username":"songhuang","avatar_url":"https://jihulab.com/uploads/-/system/user/avatar/4000/avatar.png","email":"[REDACTED]"},"project":{"id":13953,"name":"GitLab","description":"","web_url":"https://jihulab.com/gitlab-cn/gitlab","avatar_url":"https://jihulab.com/uploads/-/system/project/avatar/13953/1-Logo-Stacked-Gray-Square.png","git_ssh_url":"git@jihulab.com:gitlab-cn/gitlab.git","git_http_url":"https://jihulab.com/gitlab-cn/gitlab.git","namespace":"gitlab-cn","visibility_level":20,"path_with_namespace":"gitlab-cn/gitlab","default_branch":"main-jh","ci_config_path":"jh/.gitlab-ci.yml","homepage":"https://jihulab.com/gitlab-cn/gitlab","url":"git@jihulab.com:gitlab-cn/gitlab.git","ssh_url":"git@jihulab.com:gitlab-cn/gitlab.git","http_url":"https://jihulab.com/gitlab-cn/gitlab.git"},"object_attributes":{"assignee_id":137,"author_id":137,"created_at":"2022-08-03 01:09:04 +0800","description":"## What does this MR do and why?\n\ncloses https://jihulab.com/gitlab-cn/gitlab/-/issues/1408 \n\nDue to https://jihulab.com/gitlab-cn/gitlab/-/blob/22f71dce6990e17bea6c262919d6ae480ffdabf2/config/application.rb#L349, all assets path should be push before `#{config.root}/node_modules`, and we don't want to couple logic like adding JH modules to assets with upstream any more like what we did in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/88207. With this MR, we make adding JH path works in `/jh` folder and decouple with upstream. \n\n## Screenshots or screen recordings\n![image](https://jihulab.com/gitlab-cn/gitlab/uploads/b5048ca1fc10930f53c4ccb752d54893/image.png)\n\n![image](https://jihulab.com/gitlab-cn/gitlab/uploads/fdf8f7ab23078652b6571b7e00f87e36/image.png)\n## How to set up and validate locally\n\n1. create `node_modules/@jihu-fe/svgs/dist/illustrations/test/test.svg`\n1. start gitlab in gdk\n1. uses the svg any where in rails\n\n\n\n## MR acceptance checklist\n\nThis checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.\n\n* [x] I have evaluated the [MR acceptance checklist](https://docs.gitlab.com/ee/development/code_review.html#acceptance-checklist) for this MR.\n\n<!-- template sourced from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/Default.md -->","head_pipeline_id":436539,"id":102197,"iid":747,"last_edited_at":"2022-08-03 09:21:28 +0800","last_edited_by_id":137,"merge_commit_sha":null,"merge_error":null,"merge_params":{"force_remove_source_branch":"1"},"merge_status":"can_be_merged","merge_user_id":null,"merge_when_pipeline_succeeds":false,"milestone_id":1403,"source_branch":"add-insert-assets-path-in-initializer","source_project_id":13953,"state_id":1,"target_branch":"main-jh","target_project_id":13953,"time_estimate":0,"title":"Add insert assets path initializer","updated_at":"2022-08-03 11:58:06 +0800","updated_by_id":4000,"url":"https://jihulab.com/gitlab-cn/gitlab/-/merge_requests/747","source":{"id":13953,"name":"GitLab","description":"","web_url":"https://jihulab.com/gitlab-cn/gitlab","avatar_url":"https://jihulab.com/uploads/-/system/project/avatar/13953/1-Logo-Stacked-Gray-Square.png","git_ssh_url":"git@jihulab.com:gitlab-cn/gitlab.git","git_http_url":"https://jihulab.com/gitlab-cn/gitlab.git","namespace":"gitlab-cn","visibility_level":20,"path_with_namespace":"gitlab-cn/gitlab","default_branch":"main-jh","ci_config_path":"jh/.gitlab-ci.yml","homepage":"https://jihulab.com/gitlab-cn/gitlab","url":"git@jihulab.com:gitlab-cn/gitlab.git","ssh_url":"git@jihulab.com:gitlab-cn/gitlab.git","http_url":"https://jihulab.com/gitlab-cn/gitlab.git"},"target":{"id":13953,"name":"GitLab","description":"","web_url":"https://jihulab.com/gitlab-cn/gitlab","avatar_url":"https://jihulab.com/uploads/-/system/project/avatar/13953/1-Logo-Stacked-Gray-Square.png","git_ssh_url":"git@jihulab.com:gitlab-cn/gitlab.git","git_http_url":"https://jihulab.com/gitlab-cn/gitlab.git","namespace":"gitlab-cn","visibility_level":20,"path_with_namespace":"gitlab-cn/gitlab","default_branch":"main-jh","ci_config_path":"jh/.gitlab-ci.yml","homepage":"https://jihulab.com/gitlab-cn/gitlab","url":"git@jihulab.com:gitlab-cn/gitlab.git","ssh_url":"git@jihulab.com:gitlab-cn/gitlab.git","http_url":"https://jihulab.com/gitlab-cn/gitlab.git"},"last_commit":{"id":"36af1d720c65d9806df49f64ad7688f267740b4e","message":"Add insert assets path initializer\n","title":"Add insert assets path initializer","timestamp":"2022-08-03T10:22:14+08:00","url":"https://jihulab.com/gitlab-cn/gitlab/-/commit/36af1d720c65d9806df49f64ad7688f267740b4e","author":{"name":"Kun Qian","email":"kunqian@jihulab.com"}},"work_in_progress":false,"total_time_spent":0,"time_change":0,"human_total_time_spent":null,"human_time_change":null,"human_time_estimate":null,"assignee_ids":[137],"labels":[{"id":777,"title":"backend","color":"#808080","project_id":null,"created_at":"2021-08-20 17:26:35 +0800","updated_at":"2021-08-20 17:26:35 +0800","template":false,"description":null,"type":"GroupLabel","group_id":845},{"id":2022,"title":"feature::enhancement","color":"#3cb371","project_id":null,"created_at":"2021-11-18 11:03:39 +0800","updated_at":"2022-05-18 17:13:22 +0800","template":false,"description":"User-facing improvements that refine the initial MVC to make it more useful and usable","type":"GroupLabel","group_id":845},{"id":11897,"title":"tech debt","color":"#cd5b45","project_id":null,"created_at":"2022-04-24 16:26:06 +0800","updated_at":"2022-04-24 16:26:06 +0800","template":false,"description":"","type":"GroupLabel","group_id":845}],"state":"opened","blocking_discussions_resolved":false,"first_contribution":false,"action":"update"},"labels":[{"id":777,"title":"backend","color":"#808080","project_id":null,"created_at":"2021-08-20 17:26:35 +0800","updated_at":"2021-08-20 17:26:35 +0800","template":false,"description":null,"type":"GroupLabel","group_id":845},{"id":2022,"title":"feature::enhancement","color":"#3cb371","project_id":null,"created_at":"2021-11-18 11:03:39 +0800","updated_at":"2022-05-18 17:13:22 +0800","template":false,"description":"User-facing improvements that refine the initial MVC to make it more useful and usable","type":"GroupLabel","group_id":845},{"id":11897,"title":"tech debt","color":"#cd5b45","project_id":null,"created_at":"2022-04-24 16:26:06 +0800","updated_at":"2022-04-24 16:26:06 +0800","template":false,"description":"","type":"GroupLabel","group_id":845}],"changes":{"labels":{"previous":[{"id":777,"title":"backend","color":"#808080","project_id":null,"created_at":"2021-08-20 17:26:35 +0800","updated_at":"2021-08-20 17:26:35 +0800","template":false,"description":null,"type":"GroupLabel","group_id":845},{"id":11897,"title":"tech debt","color":"#cd5b45","project_id":null,"created_at":"2022-04-24 16:26:06 +0800","updated_at":"2022-04-24 16:26:06 +0800","template":false,"description":"","type":"GroupLabel","group_id":845}],"current":[{"id":777,"title":"backend","color":"#808080","project_id":null,"created_at":"2021-08-20 17:26:35 +0800","updated_at":"2021-08-20 17:26:35 +0800","template":false,"description":null,"type":"GroupLabel","group_id":845},{"id":2022,"title":"feature::enhancement","color":"#3cb371","project_id":null,"created_at":"2021-11-18 11:03:39 +0800","updated_at":"2022-05-18 17:13:22 +0800","template":false,"description":"User-facing improvements that refine the initial MVC to make it more useful and usable","type":"GroupLabel","group_id":845},{"id":11897,"title":"tech debt","color":"#cd5b45","project_id":null,"created_at":"2022-04-24 16:26:06 +0800","updated_at":"2022-04-24 16:26:06 +0800","template":false,"description":"","type":"GroupLabel","group_id":845}]}},"repository":{"name":"GitLab","url":"git@jihulab.com:gitlab-cn/gitlab.git","description":"","homepage":"https://jihulab.com/gitlab-cn/gitlab"},"assignees":[{"id":137,"name":"Kun Qian","username":"qk44077907","avatar_url":"https://jihulab.com/uploads/-/system/user/avatar/137/avatar.png","email":"kunqian@jihulab.com"}]},"results":[{"processor":"Triage::AddParentLabel","message":null,"error":"Server responded with code 400, message: 400 Bad request - Note {:note=>[\"can't be blank\"]}. Request URI: https://jihulab.com/api/v4/projects/13953/merge_requests/747/notes","duration":0.11531}],"duration":0.37668,"request_id":"fd2fe9ed7bdb6e21383c32ac31cdf23c"}
/cc @qk44077907
由 Song Huang 编辑于