Skip to content

Draft: Download assets from generic package for JH

奇廷 陈请求将add_cache-assets_for_jh合并到main-jh

What does this MR do and why?

Recently, an upstream MR ci: Download assets from generic package added three pipeline jobs:

  1. cache-assets:test
  2. cache-assets:test as-if-foss
  3. cache-assets:production

Before rules:

  • never run unless $CACHE_ASSETS_AS_PACKAGE == "true"
  • runs automatically for all GitLab.com gitlab-org/gitlab scheduled pipelines
  • runs automatically for GitLab.com's default branch commit that touches the assets-related folders
  • is manual for GitLab.com's gitlab-org's MRs that touches caching-related files

These rules make cache-assets only take effect under the gitlab.com domain.

For JH, we need to rewrite the cache-assets rules to accommodate jihulab.com.

After rules:

  • never run unless $CACHE_ASSETS_AS_PACKAGE == "true"
  • runs automatically for all jihulab.com gitlab-cn/gitlab scheduled pipelines
  • runs automatically for jihulab.com's default branch commit that touches the assets-related folders
  • is manual for jihulab.com's gitlab-cn's MRs that touches caching-related files

How to set up and validate locally

  1. Pull the current branch add_cache-assets_for_jh and create a new branch from the current branch.
  2. Change scripts/gitlab_component_helpers.sh by adding a few spaces, commit and push.
  3. See the pipeline and cache-assets:test, cache-assets:test as-if-foss, cache-assets:production appear.

Screenshot for jobs

Snipaste_2022-09-29_20-48-05

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

奇廷 陈 编辑于

合并请求报告

加载中