Skip to content

Resolve "Add i18n for email_validation shared example spec"

What does this MR do and why?

The spec/support/shared_examples/features/trial_email_validation_shared_example.rb shared_examples in JH is failing.

This MR is to solve this problem.

The reasons are as follow:

  1. JH behaves differently from upstream: email_hint_message does not exist in the Jihu register interface.
  2. JH's trial_email_validation=false setting does not take effect.

Solution:

  1. Rewrite trial_email_validation_shared_example under JH and add test cases to cover it.
  2. Add test cases as jh_related_spec to the filter group in skip_specs.yml.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #1541 (closed)

奇廷 陈 编辑于

合并请求报告

加载中