Skip to content

Resolve third party login i18n

Martin Tan请求将1208-third-party-login-i18n合并到main-jh

upstream MR

What does this MR do and why?

  • Fix translation on omniauth_error page
  • Fix translation for terms message

Screenshots or screen recordings

Before After
image image
image image

How to set up and validate locally

  1. Register a new user on JiHu
  2. Register a new user on GitHub with the same email from previous step
  3. Goto sign up page on JiHu
  4. Click on GitHub button
  5. You should see the omniauth_error page is translated into :zh_CN

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #1208 (closed)

Martin Tan 编辑于

合并请求报告

加载中