Fix Cannot Show Quick Action Success Message
upstream modify note.errors content key from [:commands_only] to [:commands_only, :command_names], which break the logic of showing successful quick action response, like below, quick action is successfully run, but dingtalk response still return failure message.
Currently I quick fix by duplicate logic from app/controllers/concerns/notes_actions.rb:63, however I think we need refactor upstream code to introduce method in Note#success_quick_actions? to avoid break JH feature again. Because JH 15.1 is release soon, so I prefer duplicate it to fix first.
what's more, I try to add test to cover this logic in dingtalk_spec.rb, however I found test create note in issue will raise exceed 100 db query in test exception, so I have to mock note_create_service. I will also raise this issue to upstream.
Related fix MR: !639 (merged)