Skip to content

Fix phone login with MFA

Martin Tan请求将1110-fix-phone-login-with-mfa合并到main-jh

related issue #1110 (closed)

User can't login with phone number when MFA is enabled. The phone login feature is introduced in this MR !440 (merged)

Proposal

  • Allow phone login with MFA enabled
  • Add feature flag check for sign-in username label

UI

Before After
image image

How to test

  1. Given a user with MFA enabled
  2. And feature enabled Feature.enable :phone_authenticatable
  3. When goto sign in page
  4. Then the username label should be 用户名/邮箱/手机号
  5. And Two factor auth is required after you submit the form
Martin Tan 编辑于

合并请求报告