Skip to content

Fix test failures cased by MR before

张泽华请求将fix/pipeline-failures-220406合并到main-jh

What does this MR do and why?

Related MR !406 (merged), this MR introduces two new test failures https://jihulab.com/gitlab-cn/gitlab/-/jobs/2491683 https://jihulab.com/gitlab-cn/gitlab/-/jobs/2491682

  1. Fix typo image

  2. verify_code_received_by_phone condition change to ::Gitlab.com? && ::Gitlab.jh? && ::Feature.enabled?(:real_name_system). So I need change test of jh/spec/controllers/jh/users/terms_controller_spec.rb to stub the return of ::Gitlab.com? image

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

张泽华 编辑于

合并请求报告

加载中