Fix test failures cased by MR before
What does this MR do and why?
Related MR !406 (merged), this MR introduces two new test failures https://jihulab.com/gitlab-cn/gitlab/-/jobs/2491683 https://jihulab.com/gitlab-cn/gitlab/-/jobs/2491682
-
verify_code_received_by_phone
condition change to::Gitlab.com? && ::Gitlab.jh? && ::Feature.enabled?(:real_name_system)
. So I need change test ofjh/spec/controllers/jh/users/terms_controller_spec.rb
to stub the return of::Gitlab.com?
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
由 张泽华 编辑于