Skip to content

Fix pipeline failure of manager_spec and login_spec

张泽华请求将fix/login-spec合并到main-jh
  1. jh/spec/lib/jh/backup/manager_spec.rb This test failed because upstream changed the code of lib/backup/manager.rb and moved remove_old to private method. So I modified the test to accommodate the change.

  2. spec/features/users/login_spec.rb

Failure/Error: expect(page).to have_content('Please accept the Terms of Service before continuing.')
     expected to find text "Please accept the Terms of Service before continuing." in "Please verify your phone before continuing. These are the terms If you do not agree with these conditions, you can contact Jihu GitLab support team for helping you with your current account Phone +86 +852 +853 +886 +1 +81 +60 +61 +44 +65 +49 +7 +20 +27 +30 +31 +32 +33 +34 +36 +39 +40 +41 +43 +45 +46 +47 +48 +52 +53 +54 +55 +62 +63 +64 +66 +82 +84 +90 +91 +92 +95 +351 +352 +353 +354 +355 +356 +357 +358 +359 +370 +371 +372 +373 +374 +375 +376 +377 +378 +380 +386 +420 +421 +423 +855 +856 +880 +966 +967 +968 +971 +972 +973 +974 +976 +381 Verification code Get code Decline and sign out Accept terms"

This test failed because we changed the login page, so the test cannot find expected text, but this assertion is defined in the expect_to_be_on_terms_page method of spec/support/helpers/terms_helper.rb, so I override this method and test can pass.

合并请求报告

加载中