Skip to content

Remove team plan FF

路志远请求将remove-ff-team-plan合并到main-jh

What does this MR do and why?

Close https://jihulab.com/gitlab-cn/gitlab/-/issues/4261

  1. 移除 FF jh_saas_team_plan
  2. 新增 FF jh_only_block_seat_for_team_plan,默认打开
  3. 更新官网 Pricing 链接:https://gitlab.cn/pricing/?type=saas

为什么不完全移除 FF,而是又增加了一个新的 FF?

目前,我们和 Upstream 在限制 Seats 的策略上存在一个差异:我们只限制团队版,Upstream 限制所有版本。所以 JH 这边需要做一些改动(如下图),同时这会导致 Upstream 大量的测试失败(例如 pipelines/2936350)。

但在未来,我们是要和 Upstream 保持统一的(Slack 讨论记录)。

所以相比现在覆写 Upstream 大量的测试,更方便的做法是,为这个差异增加一个 FF,保留 Upstream 的测试。这样在未来的改动中,也会方便很多。

image

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

路志远 编辑于

合并请求报告

加载中