Skip to content

Sync Upstream function about "fill_in_checkout_form"

路志远请求将fix-pipeline-2443201合并到pre-main-jh

What does this MR do and why?

Fix Pipeline: https://jihulab.com/gitlab-cn/gitlab/-/pipelines/2443201

Failed job 1: About fill_in_checkout_form

Failures:
  1) Subscription flow for user picking company for paid plan with sso sign up registers the user, processes subscription purchase and creates a group
     Got 0 failures and 2 other errors:
     1.1) Failure/Error: fill_in_checkout_form(has_billing_account: has_billing_account)
          ArgumentError:
            wrong number of arguments (given 1, expected 0)
          # ./jh/spec/support/helpers/jh/saas_registration_helpers.rb:18:in `fill_in_checkout_form'

Upstream 修改了函数 fill_in_checkout_form（Upstream MR），极狐之前 override 过它，现在也做同样的更新即可。

Failed job 2:

Failures:
  1) User comments on a merge request behaves like edits content using the content editor autocomplete suggestions shows suggestions for members with descriptions
     Got 1 failure and 1 other error:
     Shared Example Group: "edits content using the content editor" called from ./spec/features/merge_request/user_comments_on_merge_request_spec.rb:36
     1.1) Failure/Error: expect(find(suggestions_dropdown)).to have_text('all')
            expected to find text "all" in "abc123 abc123 namespace2 Sidney Jones3"
            Timeout (30s) reached while running a waiting Capybara finder.
            Consider using a non-waiting finder.

这是昨天 Upstream 出现过的错误（Upstream Failed Job），我们等待同步代码即可。

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

由 路志远 编辑于

合并请求报告