Skip to content

Fix spec of oauth and subscription

路志远请求将fix-pipeline-2432749合并到pre-main-jh

What does this MR do and why?

Fix Pipeline https://jihulab.com/gitlab-cn/gitlab/-/pipelines/2432749

Failed Job 1

Job: https://jihulab.com/gitlab-cn/gitlab/-/jobs/12500221

Related Upstream MR: Remove oauth-login-... ID from SSO sign ups

  1) OAuth Registration provider: :cas3, additional_info: {} when block_auto_created_users is false when registering via an invitation email redirects to the activity page with all the projects/groups invitations accepted
     Got 0 failures and 2 other errors:
     1.1) Failure/Error: super
          Capybara::ElementNotFound:
            Unable to find link or button "oauth-login-cas3"
            Timeout (30s) reached while running a waiting Capybara finder.
            Consider using a non-waiting finder.

Failed Job 2

Job: https://jihulab.com/gitlab-cn/gitlab/-/jobs/12500219

Related Upstream MR: Fix symbol/string :errors/'errors' confusion in GQL client

Failures:
  1) Gitlab::SubscriptionPortal::Client#subscriptions when plan_code is only_ci_minutes behaves like when response code is 422 returns the error message along with the error_attribute_map
     Failure/Error: expect(subject[:data][:error_attribute_map]).to eq(error_attribute_map)
       expected: {:email=>["taken"]}
            got: {"email"=>["taken"]}
       (compared using ==)
       Diff:
       @@ -1 +1 @@
       -:email => ["taken"],
       +"email" => ["taken"],

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

路志远 编辑于

合并请求报告

加载中