Skip to content

Fix bug of integration render?

Baodong请求将fix-integration-render合并到main-jh

What does this MR do and why?

Bug issue: #3853 (closed)

Bug related code:

Each Project Object has one ProjectSetting Object, which contains some cache fields, such as has_confluence has_shimo.

Both Shimo and Confluence inherit from BaseThirdPartyWiki, there is after_commit ActiveRecord hook to update has_xxx cache fields .

However, this hook will be skipped, causing the cached fields on the ProjectSetting to not be updated correctly when updating the group integration config

(through BulkCreateIntegrationService and BulkUpdateIntegrationService ).

after_commit method:

How to fix on JH

Ignore the inaccurate field of ProjectSetting and directly take the status of Integration.

Screenshots or screen recordings

groups and projects integrations table
截屏2023-11-24_21.59.20 截屏2023-11-24_22.05.59

How to set up and validate locally

  • Create groups and projects
└── root-group
    ├── proj-1
    └── sub-group
        └── proj-2
  • Create shimo integration for root-group, active
  • Check shimo in sub projects
  • Inactive shimo integration for root-group
  • Check shimo in sub projects

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Baodong 编辑于

合并请求报告

加载中