Skip to content

Fix pipeline 2106789

路志远请求将fix-pipeline-2106789合并到main-jh

What does this MR do and why?

1. test/rspec unit pg14 26/28

By Linjie.

Related upstream MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/132331

Failures:
  1) API::Entities::WikiPage with front matter content returns the raw wiki page content
     Failure/Error: expect(subject[:content]).to eq content_with_front_matter
       expected: "---\nxxx: abc\n---\nHome Page"

2. rspec unit pg14 5/28

Related Upstream MR:https://gitlab.com/gitlab-org/gitlab/-/merge_requests/132793/diffs

Failures:
  1) admin/sessions/new.html.haml omniauth authentication enabled shows omniauth form
     Failure/Error: expect(rendered).to have_css('.omniauth-divider')
       expected to find css ".omniauth-divider" but there were no matches

在之前,前端其实一直都有问题,在最近的 Upstream MR 提交后才被 Spec 中检查到:Admin mode 下的登录页面缺少「or sign in with」。当前 MR 修复了它。

Before After

3. rspec-ee unit pg14 13/18

Related Upstream MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/133257/diffs

Failures:
  1) Gitlab::Email::Message::AccountValidation contains the correct message
     Failure/Error: expect(message.address).to include('GitLab Inc')
       expected "<b>JiHu(GitLab)</b> Room 09, No. 03, 2nd Floor, IT Service Center, No. 1 Guanshan 1st Road, East Lake New Technology Development Zone (Wuhan Area of Free Trade Zone), Wuhan" to include "GitLab Inc"

4. rspec-ee unit pg14 5/18

Related Upstream MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/124811/diffs

Failures:
  1) ComplianceManagement::PendingStatusCheckWorker#perform creates status checks on MR
     Failure/Error: unscoped { yield relation, index }
     ArgumentError:
       'pending' is not a valid status

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

路志远 编辑于

合并请求报告

加载中