Fix profile editor bug on SaaS
What does this MR do and why?
Related issue: https://jihulab.com/gitlab-cn/gitlab/-/issues/3261
Related MR: !1803 (merged)
Root reason:
The upstream modified the user parameter in controller, causing jh's pipeline to fail, and the wrong param fixing caused this bug.
This bug will only trigger when the phone_verification_code_enabled
is turned on, so the unit test has no early warning.
How to fix:
- Add new unit tests to cover the bug cases;
- Refactor
user
new_user
params key, make them automatically adapt to changes.
Screenshots or screen recordings
Run new UT on main-jh | Run new UT on this branch |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.