Skip to content

Fix profile editor bug on SaaS

Baodong请求将fix-profile-bug合并到main-jh

What does this MR do and why?

Related issue: https://jihulab.com/gitlab-cn/gitlab/-/issues/3261

Related MR: !1803 (merged)

Root reason:

The upstream modified the user parameter in controller, causing jh's pipeline to fail, and the wrong param fixing caused this bug.

This bug will only trigger when the phone_verification_code_enabled is turned on, so the unit test has no early warning.

How to fix:

  • Add new unit tests to cover the bug cases;
  • Refactor user new_user params key, make them automatically adapt to changes.

Screenshots or screen recordings

Run new UT on main-jh Run new UT on this branch
user_uploads_avatar_to_profile_their_new_avatar_is_immediately_visible_in_the_header_and_setting_sid Screenshot_from_2023-07-17_23-44-45

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

合并请求报告

加载中