Skip to content

Set requires_webhook=false for wecom

路志远请求将fix-pipeline-1354611-about-wecom合并到main-jh

What does this MR do and why?

What

Fix pipeline: https://jihulab.com/gitlab-cn/gitlab/-/pipelines/1354611/failures

Failure/Error: connection.public_send(...)
      ActiveRecord::RecordInvalid:
        Validation failed: Webhook can't be blank, Webhook must be a valid URL, Labels to be notified behavior is not included in the list, Please input valid Wecom group robot webhook key

Why

!1809 (merged) 引入了 wecom integration, integration 默认 webhook 是必需字段,但测试时没有传递此字段。

事实上 wecom integration 并不需要 webhook,所以我们应该将 webhook 设置为非必需字段。

def requires_webhook?
  false
end

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

路志远 编辑于

合并请求报告

加载中