Skip to content

Add RemoveShimoZentaoIntegrationRecords skip rule

What does this MR do and why?

Failed job: https://jihulab.com/gitlab-cn/gitlab/-/jobs/7635643

Changes from: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/88908/diffs

rspec ./jh/spec/features/issues/form_spec.rb:58 # New/edit issue new issue allows user to create new issue
rspec ./jh/spec/features/issues/form_spec.rb:136 # New/edit issue new issue displays an error message when submitting an invalid form

Stub FF visible_label_selection_on_metadata.


Failed job: https://jihulab.com/gitlab-cn/gitlab/-/jobs/7632376

Changes from: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/114721

Because context 'with CE/EE env' do, this test only needs to be run in the EE environment.

So skip it in JH.

Next plan

Plan 1:

Add mock to upstream test.

    before do
      allow(Gitlab).to receive(:jh?).and_return(false)
    end

Plan 2:

Add test tab skip_in_jh to the upstream

context 'with JiHu env', :skip_in_jh do
# sth...
end

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Baodong 编辑于

合并请求报告

加载中