Use ULTIMATE_FEATURES_WITH_USAGE_PING in JH
What does this MR do and why?
What
- Failed pipeline: https://jihulab.com/gitlab-cn/gitlab/-/pipelines/1196908
- Failed Jobs: https://jihulab.com/gitlab-cn/gitlab/-/jobs/7627533
- Change from Upstream MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/119510
Error log
Failure/Error:
stub_licensed_features(security_dashboard: true, sast: true, sast_iac: true, dast: true,
dependency_scanning: true, container_scanning: true, coverage_fuzzing: true,
api_fuzzing: true, security_configuration_in_ui: true)
ArgumentError:
coverage_fuzzing should be defined as licensed feature
Why
Upstream migrates a feature coverage_fuzzing
from ULTIMATE_FEATURES
to ULTIMATE_FEATURES_WITH_USAGE_PING
: Upstream MR
Since JH overwrites ALL_ULTIMATE_FEATURES
, coverage_fuzzing
is missing from the final ALL_ULTIMATE_FEATURES
.
The current MR is used to supplement coverage_fuzzing
to ULTIMATE_FEATURES
.
Before:
# Upstream
ULTIMATE_FEATURES = %i[feature1 feature2 coverage_fuzzing]
ALL_ULTIMATE_FEATURES = ULTIMATE_FEATURES
# Jihu
del ALL_ULTIMATE_FEATURES
ALL_ULTIMATE_FEATURES = ULTIMATE_FEATURES
After:
# Upstream
ULTIMATE_FEATURES = %i[feature1 feature2]
ULTIMATE_FEATURES_WITH_USAGE_PING = %i[coverage_fuzzing]
ALL_ULTIMATE_FEATURES = ULTIMATE_FEATURES + ULTIMATE_FEATURES_WITH_USAGE_PING
# Jihu
del ALL_ULTIMATE_FEATURES
ALL_ULTIMATE_FEATURES = ULTIMATE_FEATURES + ULTIMATE_FEATURES_WITH_USAGE_PING
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
由 路志远 编辑于